Skip to content

ci: run release-please from the shared reusable workflow - #12

Merged
kristoflemmens merged 1 commit into
mainfrom
ci/shared-release-please
Nov 17, 2026
Merged

kristoflemmens merged 1 commit into
mainfrom
ci/shared-release-please

Conversation

@kristoflemmens

Copy link
Copy Markdown
Contributor

The release-please job in release.yml now calls
release-please.yml
of klconsultancy/workflows, pinned to c950259 (main).

  • Same GitHub App: vars.RELEASE_APP_CLIENT_ID and the secret RELEASE_APP_PRIVATE_KEY, passed by name.
  • The job's token permissions drop to {}: release-please already acted with the app token, never with GITHUB_TOKEN.
  • Release candidates stay off (no tag trigger), so nothing new runs.
  • publish is unchanged and stays in release.yml: npm's trusted publisher is bound to this workflow file and the npm environment. It still needs: release-please, runs on release_created == 'true' and checks out tag_name; the reusable workflow exposes both outputs under the same names.
  • The job's check is now release-please / Release PR (not a required check). CI (test) is untouched.

🤖 Generated with Claude Code

The release-please job now calls release-please.yml of klconsultancy/workflows
(pinned to main), with the same GitHub App credentials. The npm publish job
stays in release.yml, where the trusted publisher expects it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kristoflemmens
kristoflemmens merged commit 8d3c80e into main Nov 17, 2026
2 checks passed
@kristoflemmens
kristoflemmens deleted the ci/shared-release-please branch November 19, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant