Repository navigation
ci: run release-please from the shared reusable workflow - #12
Merged
Merged
Conversation
The release-please job now calls release-please.yml of klconsultancy/workflows (pinned to main), with the same GitHub App credentials. The npm publish job stays in release.yml, where the trusted publisher expects it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
release-pleasejob inrelease.ymlnow callsrelease-please.ymlof
klconsultancy/workflows, pinned toc950259(main).vars.RELEASE_APP_CLIENT_IDand the secretRELEASE_APP_PRIVATE_KEY, passed by name.{}: release-please already acted with the app token, never withGITHUB_TOKEN.publishis unchanged and stays inrelease.yml: npm's trusted publisher is bound to this workflow file and thenpmenvironment. It stillneeds: release-please, runs onrelease_created == 'true'and checks outtag_name; the reusable workflow exposes both outputs under the same names.release-please / Release PR(not a required check). CI (test) is untouched.🤖 Generated with Claude Code