Repository navigation
chore: support working in git worktrees - #3
Merged
Merged
Conversation
- give every worktree its own .venv (drop UV_PROJECT_ENVIRONMENT) - trust .worktrees/* as git safe.directory in the devcontainer - ignore .worktrees/ in git and ruff - run the lint job on Python 3.14, like the devcontainer - document the worktree workflow in AGENTS.md, README and design.md Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 of 4 tasks
kristoflemmens
added a commit
that referenced
this pull request
Oct 25, 2026
## What and why Closes #32 Field confirmations from other Genesis implementations and the reference pump, recorded in `docs/errata.md`. - **Input 83–84 "Electric meter kWh total":** the row now cites the field report. Users of CJNE/thermiagenesis saw wrong kWh totals while it read MSB first (#292; a Calibra, firmware 16.00 per a later comment), and pythermiagenesis switched to LSB first at scale 10 (#3). No correct reading after that switch has been reported, so the row keeps *to be verified on a pump with an electric meter (17.1)*. - **Holding 118 "Outdoor temperature sensor":** it reads 20000 until a BMS writes it (reference pump: 117 = 0, 118 = 20000). A written value takes effect only when holding 117 selects the BMS (infradom/thermia-genesis-calibra-modbus-hints#1). Per its own description (chapters 3 and 4), the pump falls back to its own sensor when 118 isn't refreshed within 12 hours. **Already handled elsewhere, from the same issue:** - Input 121 (scale 10, and 2000 when the sensor is absent): #40. - Holding 61–63 in seconds: #36, with the documentary sources in #38. - Inputs 325–328 and 412 reading 2000 support the scale-10 absent value (#40). Coil 24 belongs with the undocumented registers (#35). **Not added:** the confirmation that the operating hours are MSB first (input 48–51, checked against the myThermia export and the display). That is neither a contradiction nor undocumented behaviour, and the errata only list those. The map and the fixture already pin the order. Docs only; no code changes. ## Checklist - [ ] The test was written first and failed for the right reason before the implementation (n/a: docs only) - [x] Coverage stays at 100% - [x] `docs/design.md` / `CONTEXT.md` updated if a design choice or domain term changed (errata only) - [x] PR title follows Conventional Commits (`feat:`, `fix:`, `docs:`, ...) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
All changes are made in git worktrees under
.worktrees/<branch>instead of the main checkout. This PR makes the repository and devcontainer work that way, as agreed after #1 (and covers the deferred review points from #1).UV_PROJECT_ENVIRONMENTis removed, so uv creates.venvinside each worktree. Parallel worktrees no longer overwrite each other's editable install. VS Code's default interpreter now points at${containerWorkspaceFolder}/.venv.postCreateCommandalso trusts${containerWorkspaceFolder}/.worktrees/*assafe.directory. Combined withworktree.useRelativePaths(set once per clone, documented), worktree.gitfiles resolve inside the container..worktrees/in.gitignoreand in ruff'sextend-exclude.AGENTS.md(commands),README.md(development) anddocs/design.md(process).Verified locally
Rebuilt the devcontainer from this branch's config (Python 3.14.8, uv 0.13.5). From the worktree:
git statusworks in the container,uv run --directory .worktrees/worktree-workflow pytestpasses with 100% coverage, all prek hooks pass, and the main checkout and the worktree each have their own.venv.Checklist
docs/design.md/CONTEXT.mdupdated if a design choice or domain term changed🤖 Generated with Claude Code