Repository navigation
ci: bump the package version in uv.lock on release - #43
Merged
Merged
Conversation
release-please bumped pyproject.toml but left uv.lock at the old version, so uv sync --locked failed on the release PR. Let it update the thermia-genesis entry in uv.lock too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kristoflemmens
commented
Oct 25, 2026
kristoflemmens
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed c0ec906 (only release-please-config.json; 61 files, the same as main). No concrete findings: the jsonpath is correct.
Version: release-please-action v5.0.0 (45996ed) depends on release-please ^17.6.0, locked at 17.6.0.
Source code (v17.6.0):
src/updaters/generic-toml.tsparses withparseWith()fromsrc/util/toml-edit.ts. ItsTaggedTOMLParserreplaces every scalar value with a tagged object{start, end, value}, while tables and arrays stay ordinary objects.- So in a JSONPath filter,
@.nameis an object, and@.name.valueis the string. That makes$.package[?(@.name.value=='thermia-genesis')].versionthe right form. - The result is resolved to a pointer (
/package/<i>/version), andreplaceTomlValuereplaces only the byte range of that value, so the rest of the formatting stays intact.
Verified with the real updater: I installed release-please@17.6.0 in an isolated directory and ran GenericToml with this jsonpath and version 0.1.0 on uv.lock from main.
- Result: exactly 1 line changes, line 1026,
version = "0.0.0"→version = "0.1.0"in the[[package]]ofthermia-genesis. - Unaffected: the references
{ name = "thermia-genesis", extra… }in the dependency groups stay as they are, because they don't sit directly under$.package. - Counter-check: without
.value(@.name=='thermia-genesis'), the updater logs "No entries modified" and changes nothing. The.valueis therefore required.
uv accepts the result: with pyproject.toml at 0.1.0, uv lock --check fails on the old lock, as on #16, and succeeds on the updated lock ("Resolved 49 packages"). uv sync --locked --dry-run then works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Refs #15
CI fails on the release PR #16: release-please bumps
pyproject.tomlto 0.1.0 but leavesuv.lockat 0.0.0, anduv sync --lockedthen refuses the lockfile. This would happen on every release.This adds an
extra-filesentry torelease-please-config.json, so release-please also bumps thethermia-genesispackage version inuv.lock. It uses the TOML updater with$.package[?(@.name.value=='thermia-genesis')].version; release-please's TOML parser wraps values, hence.value.Verification: this can't be run locally. After the merge, the release workflow rewrites #16, which must then also change
uv.lock(version = "0.0.0"→"0.1.0"forthermia-genesis), and its CI must turn green.Also, in the same release preparation: release-please could not parse the squash commit of #26 (
feat: add the ThermiaGenesis API…). A wrapped body line starting withaddresses:read as a footer, so the changelog left out the public API. #26 now has a commit override block (the release-please feature for this) in its description, and #16 lists it after a re-run.Checklist
docs/design.md/CONTEXT.mdupdated if a design choice or domain term changed (n/a)feat:,fix:,docs:, ...)🤖 Generated with Claude Code