Repository navigation
fix(release-please): attach assets to a draft, then publish it, for immutable releases - #23
Merged
Merged
Conversation
…mmutable releases Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Scope full (first review): 2 files read, 1 finding; rules: AGENTS.md, README.md What this review covered
|
…attached Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Scope e67105c..3e5b39f: 2 files read, 1 finding; rules: AGENTS.md, README.md What this review covered
|
…atest Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Scope 3e5b39f..b4653a9: 1 files read, 0 findings; rules: AGENTS.md, README.md What this review covered
|
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ha-peak-basket has immutable releases turned on. Its first release candidate with release assets,
v0.2.0-rc.1, got its pre-release, but no zip. Upload release assets failed three times with:This workflow publishes the release first and attaches the assets afterwards, and GitHub refuses that once a release is immutable. Release-please's own releases have the same problem: release-please publishes the release before the assets job runs.
What
A release with assets is now a draft until its assets are attached.
--draftwhenassetsis set. Without assets nothing changes.assetsit does not run, so a caller that attaches files of its own in a later job keeps its draft and publishes it itself (from the review).--latest=false, the same rule as the existing maintenance-branch step.release-please-config.jsonsets"draft": trueand"force-tag-creation": true. GitHub only tags a draft when it is published, and release-please needs the tag to find the previous release. The README and the header of the workflow describe this.gh release view/upload/edit <tag>finds drafts too:FetchReleasein cli/cli looks up drafts next to published releases.No caller has to change anything, except one with assets and immutable releases whose releases come from release-please. That caller adds the two config keys.
Checks
.github/zizmor.yml: no findings.ghin five cases:--latest;--latest=false;--latest.For the rc, with assets it gets
--draftand without assets it doesn't.v0.2.0-rc.2, once its caller pins the release that contains this.🤖 Generated with Claude Code