Skip to content

Fix mixed numeric sum aggregation - #801

Merged
aannleax merged 1 commit into
knowsys:mainfrom
mattfaltyn:fix-mixed-numeric-sum
Aug 12, 2026
Merged

aannleax merged 1 commit into
knowsys:mainfrom
mattfaltyn:fix-mixed-numeric-sum

Conversation

@mattfaltyn

Copy link
Copy Markdown
Contributor

Summary

  • combine integer and float subtotals as a double in #sum
  • add a focused regression test for mixed integer/float input

Testing

  • cargo test
  • cargo fmt --all -- --check
  • cargo clippy -p nemo-physical -p nemo --all-targets -- --deny warnings --allow clippy::nonstandard_macro_braces --allow clippy::double_must_use

The two allowed clippy lints are existing diagnostics in unrelated files; the changed target is warning-free.

Fixes #800.

@aannleax

Copy link
Copy Markdown
Member

Looks good, thank you :)

@aannleax

Copy link
Copy Markdown
Member

I will fix the unrelated clippy error in another PR

@aannleax
aannleax self-requested a review August 12, 2026 11:21
@github-project-automation github-project-automation Bot moved this from Todo to In Progress in nemo Aug 12, 2026
@aannleax
aannleax force-pushed the fix-mixed-numeric-sum branch from 4179f44 to f4505be Compare August 12, 2026 11:33
@aannleax
aannleax enabled auto-merge August 12, 2026 11:36
@aannleax
aannleax merged commit 93f219c into knowsys:main Aug 12, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in nemo Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Mixed integer and float #sum drops float contribution

2 participants