Repository navigation
docs(storage): point the Isar template at packages that resolve with freezed 4 - #1136
Merged
Merged
Conversation
…freezed 4 The documented setup added isar_generator, whose 3.x releases need source_gen 1.x while freezed 4 needs source_gen 3 or later, so step 2 failed version solving. The template and the storage guide now use the community-maintained isar_community packages, which resolve here; their uncommented template, with one collection and build_runner, analyzes clean. A test keeps the two setup lists identical and off the original packages. Refs #1130 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It reads docs/api/core/storage.md, so a docs-only change must run it. Refs #1130 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t web Review of the Isar setup found that following it left `flutter analyze` failing on Isar's generated code, that the template's tests break once it is activated, and that nothing said Isar 3 cannot run on the web. The steps now put collections in one directory whose generated code is excluded from analysis, tell the adopter to delete the template's tests on activation, state the native-only platforms and name the publisher. Refs #1130 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1130
Problem
docs/api/core/storage.mdandlib/core/storage/isar_database_template.darttold an adopter to runflutter pub add --dev isar_generator. On this starter that fails version solving: everyisar_generator3.x needssource_gen1.x, andfreezed ^4needssource_gen3 or later.Change
isar_community,isar_community_flutter_libs,isar_community_generator3.4.1, publisherisar-community.dev), and explain why the originals cannot be added here.lib/core/storage/collections/, whose generated*.g.dartis excluded inanalysis_options.yaml. Isar's generated code failsvery_good_analysis.put(object)instead ofput(object as dynamic), andreturn awaitinsideasync.test/docs/isar_template_setup_test.dartkeeps the template and the guide on identicalpub addsteps and off the original packages. It fails againstmain's files and runs with the docs-only tests.Verified
main:flutter pub add --dev isar_generator --dry-runfails version solving.main(dry-run).f5fcb70):pub add.@collection Note, the exclude, andbuild_runner.NoteSchema.flutter analyzeexits 0, no committed generated file changes, andflutter test test/docs test/core/storagepasses../scripts/dev/audit_template.shexits 0 onbb71872(4126 tests); this PR's checks ran on the head.Correction to the first version of this description: it said the activated template "analyzes clean". That check counted only errors and warnings. Under
very_good_analysis, the 40+ infos on Isar's generated file makeflutter analyzeexit 1. The review caught it; the exclude in step 3 fixes it, and the exit code above is the real one.Pre-merge review
A fresh reviewer subagent ran on
bb71872with the PR, issue and diff, not the implementer's verdict. The diff toucheslib/core/storage/.Fixed on this branch (
f5fcb70):flutter analyzefailing on Isar's generated code.Supply chain, checked by the reviewer against pub.dev and GitHub:
isar-community.dev, at version 3.4.1 (2026-10-13).isar-community/isar-community, Apache-2.0, active. Its history carries over the original Isar author.isar_community_flutter_libsships prebuilt native binaries, as the original did.🤖 Generated with Claude Code