chore: remove tvOS and watchOS support - #2394
Merged
Merged
Conversation
- Drop tvos*/watchos* Kotlin targets from korge and korge-core. - Move the shared iOS implementation from iosTvosMain into iosMain and merge the expect/actual iosTools pair into a single declaration. - Delete the now-orphaned tvosMain/watchosMain sources. - Remove enableKotlinMobileTvos from gradle.properties. - Strip tvOS wiring from the Gradle plugin (tvos targets, storyboard handling, deploy extension identifiers renamed to ios*).
- Ios.kt: drop the now-constant targetName parameter from configureNativeIosTarget/configureNativeIosRun, hardcode "ios", remove the obsolete when/else->TODO branch and the duplicated target declarations.
- IosProjectTools.kt: drop the targetName parameter from the storyboard/project helpers, inline the iOS constants and remove the unused targetNameCapitalized val.
- korge/korge-core build.gradle.kts: drop the redundant iosMain { dependsOn(appleMain) } block (already handled by applyDefaultHierarchyTemplate()).
ygdrasil-io
marked this pull request as ready for review
September 14, 2026 23:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Drop tvOS and watchOS support. The
tvos*/watchos*Kotlin targets are removed fromkorgeandkorge-core, the shared iOS implementation moves fromiosTvosMainintoiosMain, and the tvOS wiring is removed from the Gradle plugin.Changes
korge-core/build.gradle.kts,korge/build.gradle.kts: removetvos*/watchos*targets and theiosTvosMainsource set;iosMainnow depends onappleMain.korge-core/src/iosTvosMain/**,korge/src/iosTvosMain/**: move shared iOS code intoiosMain/**; merge theexpect/actualiosToolsinto a singleiosTools/IosToolsImpldeclaration.korge-core/src/tvosMain/**,korge-core/src/watchosMain/**: delete.gradle.properties: dropenableKotlinMobileTvos.korge-gradle-plugin: remove tvOS targets/storyboard handling and renameiosTvos*identifiers toios*.Validation
./gradlew build --continue(macOS) → 491 tasks; 1750 tests, 57 skipped, 0 failures/errors (jvm, js, jsBrowser, wasmJs, macosArm64, iosSimulatorArm64).korge-coreandkorge(compileKotlinIosSimulatorArm64).:korge-sandbox:webApp:compileProductionExecutableKotlinWasmJsOptimize(binaryen wasm-opt "duplicate export name"), reproduced identically on unmodifiedmain— unrelated.Notes
error(...)).iosX64tests are skipped on Apple Silicon (unchanged).