Repository navigation
Conversation
CI only built and tested the .NET solution; the React frontend was never validated, and npm run lint failed with two react-hooks/set-state-in-effect errors. - Add a frontend job (npm ci, lint, build) next to the .NET job and run CI on pull requests to any base branch - Load initial dashboard and weekly schedule data in effects that only set state in promise callbacks - Refresh after generating or resetting a schedule without replacing the dashboard with the full-page loading state - Reload employee preference profiles after a demo reset; previously they stayed empty or stale until a browser reload Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Replace nine hard-coded API_BASE_URL constants with api/config.ts, configurable through VITE_API_BASE_URL (default unchanged) - translateRiskMessage removed the first '.' in 'Schedule coverage is 78.57%.', showing '7857%' whenever the API runs with an English or invariant culture (e.g. in the Docker image). Only strip the sentence-ending period. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tests use fixtures captured from the real API after a demo reset and cover the overview, error/retry, refresh behaviour after generation, preference reload after reset and the weekly schedule table. CI now runs npm test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- EF Core 9.0.7 -> 9.0.21: SQLitePCLRaw.lib.e_sqlite3 2.1.10 -> 2.1.13 (GHSA-2m69-gcr7-jv3q, high) - Swashbuckle.AspNetCore 10.1.7 -> 10.2.3: Microsoft.OpenApi 2.4.1 -> 2.7.5 (GHSA-v5pm-xwqc-g5wc, high) - Microsoft.AspNetCore.OpenApi 9.0.15 -> 9.0.21 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Read the SQLite connection string from ConnectionStrings:ShiftPlanner
(default unchanged) so tests can use an isolated database
- Expose Program to WebApplicationFactory
- POST /api/load-analysis returned 500 when an employee lacked the
skill for an assigned shift; return 400 with an error message
- Use { error } bodies for scheduling validation errors, matching the
employee and shift endpoints
- Add 20 WebApplicationFactory tests on in-memory SQLite covering
demo data, generation, simulation, analysis and validation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The model staffs each shift with exactly one employee: ShiftEntity has a single EmployeeId and no RequiredStaff column, schedule generation assigns one employee per open shift, coverage counts shifts with an employee, and simulation suggests one employee. POST /api/shifts still accepted any RequiredStaff and silently persisted 1, and the simulation UI let users request more staff than could ever be assigned. - Add Shift.SupportedRequiredStaff (1) and IsSupportedRequiredStaff as the single source of truth; use it in ShiftRepository - Return 400 for RequiredStaff != 1 on POST /api/shifts, /api/schedule/simulate and /api/load-analysis; omitted values default to 1 - Replace the simulation staffing input with a fixed note - Document the staffing model and add unit and integration tests - Run CI for pull requests to any base branch (same trigger, permissions and concurrency block as the CI PR) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… integration/stage-1-check
…integration/stage-1-check
… integration/stage-1-check
…ee' into integration/stage-1-check
Owner
Author
|
Integration check passed (all stage 1 PRs merged together, CI green). Closing as planned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary draft PR to run CI on all stage 1 PRs merged together in the recommended order (merge commits). It will be closed and the branch deleted once CI has finished. Do not merge.