Skip to content

Remove Audit references#237

Open
robobario wants to merge 1 commit into
kroxylicious:mainfrom
robobario:audit
Open

Remove Audit references#237
robobario wants to merge 1 commit into
kroxylicious:mainfrom
robobario:audit

Conversation

@robobario

Copy link
Copy Markdown
Member

We do not have an Audit Filter yet

@robobario
robobario requested a review from a team as a code owner March 8, 2026 20:49
@robobario

robobario commented Mar 8, 2026

Copy link
Copy Markdown
Member Author

couple more refs in the excalidraw overview illustrations of filter chains

edit: sorted

@robobario
robobario force-pushed the audit branch 2 times, most recently from a42cecc to 398c795 Compare March 8, 2026 21:41
@SamBarker

Copy link
Copy Markdown
Member

We don't have an audit filter/plugin but it is exactly the sort of use case we want the proxy to support. Do you think we should only show what we currently have?

Comment thread _layouts/index.html
<div class="col-lg-6">
<h1 class="fw-bold text-body-emphasis lh-1 mb-3" id="krx-hero-title">Kroxylicious, the snappy open source proxy for Apache Kafka<sup>&#174;</sup></h1>
<p class="lead">Topic encryption, policy-enforcement, multi-tenancy, audit and much more.</p>
<p class="lead">Topic encryption, policy-enforcement, multi-tenancy and much more.</p>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit.

Suggested change
<p class="lead">Topic encryption, policy-enforcement, multi-tenancy and much more.</p>
<p class="lead">Record encryption, policy-enforcement, multi-tenancy and much more.</p>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thoughts, a decision maker might not necessarily know that Kafka refers to its application messages as records. "Encryption of topic records", "Topic record encryption"?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should say encryption-at-rest to point to the bigger thing we enable here? If we use either Topic or Record they're both Kafka concepts, so I would go with Record Encryption to line up with our documentation. Though arguably some users like Operators might only think about Kafka in terms of Topics.

Anyway, can defer it from this PR

@k-wall

k-wall commented Mar 9, 2026

Copy link
Copy Markdown
Member

We don't have an audit filter/plugin but it is exactly the sort of use case we want the proxy to support. Do you think we should only show what we currently have?

I think removing the reference is the right thing. This phrase could potentially disappoint a potential user.

@robobario

Copy link
Copy Markdown
Member Author

Yeah that was my feeling, we talk about it in the same breath as other Filters we do offer, so it would be annoying to find this is the only one with no references in the documentation.

So I get what you mean that there's an audience who might be interested in the possibilities as a Filter Author, but currently it's confusing to have it mentioned in our highest level overviews and especially the hero banner on the landing page.

@SamBarker

Copy link
Copy Markdown
Member

Yeah that was my feeling, we talk about it in the same breath as other Filters we do offer, so it would be annoying to find this is the only one with no references in the documentation.

Yeah I see the concern.

So I get what you mean that there's an audience who might be interested in the possibilities as a Filter Author, but currently it's confusing to have it mentioned in our highest level overviews and especially the hero banner on the landing page.

I guess I've got a lot of the audit proposal in my head so the timing seems odd but I'm fine with merging

@robobario

Copy link
Copy Markdown
Member Author

Could be worth merging this since Audit landing time is still unclear

We do not have an Audit Filter yet

Signed-off-by: Robert Young <robertyoungnz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants