Repository navigation
feat: add positional and lazy batch record matching strategies - #68
Merged
Merged
Conversation
Introduces two batch matching strategies: POSITIONAL and LAZY. The POSITIONAL strategy requires each consumed record at index `i` to match the expected file at index `i`, while the LAZY strategy allows for order-independent matching without replacement. This enhances the flexibility of record comparisons in batch mode. BREAKING CHANGE: The MatchContext now includes a batchMatchStrategy parameter, defaulting to POSITIONAL. Update existing implementations to specify the desired strategy if different behavior is required.
Contributor
📋 Unreleased Changelog Preview
ChangelogAll notable changes to this project will be documented in this file. [Unreleased]Feat
✨ Features
🔧 Miscellaneous
Generated by git-cliff 🔄 Run #186 · Thu, 15 Oct 2026 20:03:39 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
FileRecordMatcherandAvroFileRecordMatcherpreviously only inspectedrecords.getFirst()andmatchFilePaths.getFirst()in batch mode, leaving records1..N-1unvalidated. This PR fixes both matchers to validate all consumed records against all expected files and introducesBatchMatchStrategy(POSITIONALandLAZY/ unordered 1-to-1 matching without replacement).🔄 Type of change
fix): non-breaking change that fixes an issuefeat): non-breaking change that adds functionality!): changes existing behaviour, public API, Gherkin steps or config keysrefactor): no functional changeperf)docs)build(deps))ci/build): workflows,pom.xml, tooling✅ Checklist
Code
mvn spotless:check(runmvn spotless:applyto fix it and add the Apache 2.0 headers)Tests
mvn verifypasses locally, and JaCoCo line coverage stays ≥ 70 %Compatibility & docs
New or changed HOCON keys have a default inreference.confand a documented env-var overrideNew SPI implementations are registered inMETA-INF/services/