Skip to content

Add unit tests for RealClock - #358

Closed
magic-peach wants to merge 1 commit into
kubernetes:masterfrom
magic-peach:add-clock-realclock-tests
Closed

magic-peach wants to merge 1 commit into
kubernetes:masterfrom
magic-peach:add-clock-realclock-tests

Conversation

@magic-peach

Copy link
Copy Markdown

/kind test

What this PR does / why we need it:

The clock package's RealClock implementation had no direct unit tests, only its fake counterpart in clock/testing was covered. This adds tests for Now, Since, After, Sleep, Tick, NewTimer (including Stop), AfterFunc, and NewTicker.

Test only change, no production code touched.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Ran the full go test ./... suite across all packages in the module, all pass.

Release note:

NONE

Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
@kubernetes-prow

Copy link
Copy Markdown
Contributor

@magic-peach: The label(s) kind/test cannot be applied, because the repository doesn't have them.

Details

In response to this:

/kind test

What this PR does / why we need it:

The clock package's RealClock implementation had no direct unit tests, only its fake counterpart in clock/testing was covered. This adds tests for Now, Since, After, Sleep, Tick, NewTimer (including Stop), AfterFunc, and NewTicker.

Test only change, no production code touched.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Ran the full go test ./... suite across all packages in the module, all pass.

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow
kubernetes-prow Bot requested review from aojea and thockin September 16, 2026 02:36
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-peach
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 16, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @magic-peach!

It looks like this is your first PR to kubernetes/utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 16, 2026
@skitt

skitt commented Sep 21, 2026

Copy link
Copy Markdown
Member

@kubernetes-prow kubernetes-prow Bot closed this Sep 22, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

@skitt: Closed this PR.

Details

In response to this:

See https://kubernetes.slack.com/archives/C01672LSZL0/p1789992857325439

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants