Add unit tests for RealClock - #358
magic-peach wants to merge 1 commit into
Conversation
Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
|
@magic-peach: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: magic-peach The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @magic-peach! |
|
@skitt: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind test
What this PR does / why we need it:
The
clockpackage'sRealClockimplementation had no direct unit tests, only its fake counterpart inclock/testingwas covered. This adds tests forNow,Since,After,Sleep,Tick,NewTimer(includingStop),AfterFunc, andNewTicker.Test only change, no production code touched.
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
Ran the full
go test ./...suite across all packages in the module, all pass.Release note: