Skip to content

Add tests for ObjectDiff, ObjectGoPrintDiff and ObjectGoPrintSideBySide - #360

Closed
magic-peach wants to merge 1 commit into
kubernetes:masterfrom
magic-peach:add-diff-print-functions-tests
Closed

magic-peach wants to merge 1 commit into
kubernetes:masterfrom
magic-peach:add-diff-print-functions-tests

Conversation

@magic-peach

Copy link
Copy Markdown

What type of PR is this?
/kind test

What this PR does / why we need it:

ObjectDiff, ObjectGoPrintDiff, and ObjectGoPrintSideBySide had zero test coverage, leaving the diff package at 0% before this change.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Verified with go test ./diff/...: all 9 tests pass. Package coverage goes from 0% to 88.1%.

Release note:

NONE

Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
@kubernetes-prow

Copy link
Copy Markdown
Contributor

@magic-peach: The label(s) kind/test cannot be applied, because the repository doesn't have them.

Details

In response to this:

What type of PR is this?
/kind test

What this PR does / why we need it:

ObjectDiff, ObjectGoPrintDiff, and ObjectGoPrintSideBySide had zero test coverage, leaving the diff package at 0% before this change.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Verified with go test ./diff/...: all 9 tests pass. Package coverage goes from 0% to 88.1%.

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-peach
Once this PR has been reviewed and has the lgtm label, please assign danwinship for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot requested review from aojea and thockin September 16, 2026 18:05
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2026
@skitt

skitt commented Sep 21, 2026

Copy link
Copy Markdown
Member

@kubernetes-prow kubernetes-prow Bot closed this Sep 21, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

@skitt: Closed this PR.

Details

In response to this:

See https://kubernetes.slack.com/archives/C01672LSZL0/p1789992857325439

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants