Repository navigation
fix(certmanager): drop stale in-flight handshakes after ForceRenew (F54) - #85
Merged
Merged
Conversation
A handshake that started on the pre-renewal autocert manager republished its leaf into lastCert after ForceRenew had cleared it. Publish only while the handshake's manager is still current.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A TLS handshake in flight during
ForceRenewcould write the old certificate back intolastCertafter the autocert manager was swapped.Fix:
GetCertificatepins the manager it started with;publishLeafonly publishes if that manager is still current.Regression test:
TestForceRenew_StaleHandshakeDoesNotRepublish(gated completion order). Verified 3x with-race. Note: autocert itself may still re-cache the old cert from a stale handshake; not proven, not addressed.