Run route B over the OCR markdown of a PDF set - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every ticket writes its tests before its code, and its pull request reports a run over a target set or a corpus folder with the number of flagged fields. See docs/plan.md. Write every run's output to a file under out/ before reading it.
In the corpus sweep, route B did not run on any PDF set: the sweep hands the PDF itself to
pandoc, which reads no PDF, so the MECH60014 PDF sheets report
route B failed: Unknown input format pdfand the UCL_MechEng folderno filter: pandoc reads no sheet of this set. For a PDF, route B reads the Mathpix markdown that route A reads: the filter iswritten from that markdown's tree and pandoc runs it over that markdown. The ticket is done
when the UCL_MechEng sweep runs both routes on both sheets and reports a comparison.
Workbench ticket t48.
Live sweep over UCL_MechEng with both routes (from the implementer's run, run outputs kept out of the commit)