Repository navigation
docs(bgp): propose guarded scrubber diversion - #306
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The documentation clearly separates proposed capabilities from shipped behavior, and no blocking issues remain.
No open issues 🎉
What changed in this PR
This documentation-only PR proposes guarded FlowSpec redirect-to-IP diversion for the scrubber use case in #305. It defines future safety and qualification requirements without enabling a new forwarding action.
Changes:
- Distinguishes target-IP, legacy next-hop and VRF redirect mechanisms.
- Defines configured profiles, readiness checks, isolated leases, withdrawal behavior and platform qualification gates.
- Links the proposed design from the roadmap and ADR index.
| File | Description |
|---|---|
| ROADMAP.md | Links ADR 030 and clarifies diversion prerequisites and deferred scope. |
| docs/adr/README.md | Registers ADR 030 as Proposed. |
| docs/adr/030-scrubber-diversion.md | Documents protocol research, safety requirements and phased delivery gates. |
Review effort: Balanced
lance0
marked this pull request as ready for review
October 22, 2026 22:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #305 asks to steer matched attack traffic toward a scrubber. Add a Proposed ADR and roadmap entry that distinguish redirect-to-IP, legacy next-hop redirect and redirect-to-VRF, then define a guarded delivery plan.
The research checks the current IETF draft and IANA assignments, pinned rustbgpd/GoBGP contracts, FRR, Cisco, Junos and Tempesta xFW documentation. The plan covers configured targets, isolated lease owners, fresh readiness, withdrawal on health loss, clean return paths, action conflicts, export isolation and separate evidence for local acceptance, router forwarding and scrubber behavior. It also qualifies queued adds after an RPC timeout.
Design only: no new forwarding action is enabled. Raw IPv4 transport is possible with the current rustbgpd API; lossless action handling, health and lifecycle qualification still need implementation.
Validation: two independent reviews plus source cross-checks; affected relative links/anchors and patch hygiene pass. External sources were checked live, with Cisco verified through its browser-accessible documentation. Runtime tests are unchanged.
Refs #305.