Repository navigation
chore(load): retire the hey HTTP benchmark harness - #327
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The scoped removal is consistent across scripts, verification and documentation, with no blocking issues identified; final-head hosted CI remains pending.
No open issues 🎉
What changed in this PR
Retires the hey-based HTTP load harness so routine verification no longer depends on its version-specific report format. Other testing tools and historical benchmark qualifications remain intact.
Changes:
- Deletes the HTTP load helper and its report-parser tests.
- Removes the associated just recipe, CI steps and
heyinstallation. - Updates contributor guidance, benchmark instructions and the unreleased changelog while retaining shared prerequisites.
| File | Description |
|---|---|
scripts/test-load-test.py |
Deletes the retired harness’s regression tests. |
scripts/load-test.sh |
Deletes the HTTP load generator helper. |
justfile |
Removes the load-test recipe and gate invocation. |
docs/perf/benchmarks.md |
Removes retired commands and preserves historical-result qualifications. |
CONTRIBUTING.md |
Updates verification instructions and retains shared prerequisites. |
CHANGELOG.md |
Records retirement and retains the benchmark qualification note. |
.github/workflows/ci.yml |
Removes hey installation, load checks and sample uploads. |
Review effort: Balanced
lance0
force-pushed
the
chore/retire-hey-harness
branch
from
October 24, 2026 03:22
80f2a0e to
b9f2d49
Compare
This was referenced Oct 24, 2026
lance0
marked this pull request as ready for review
October 24, 2026 04:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retire the hey HTTP load harness and its report-parser tests. Remove their just recipe/gate invocation, CI installation/check/artifact steps and active documentation commands.
Preserve Criterion, fuzz smoke, chaos, mitigation lifecycle and released-speaker tests. Historical numerical results keep their qualification limits; curl/jq/Python remain prerequisites for other helpers.
Exact head
b9f2d49passes all 13 fresh hosted checks with current dependency fixes inherited from #323. Independent source and automated reviews found no open issues. Workflow/recipe inventories, remaining references, affected links, historical-result preservation and patch hygiene pass. The combined native gate passes script checks with GNU utilities but stops in an unchanged macOS mTLS fixture; no full native gate pass is claimed.This PR targets #323 and contains only harness retirement. Merge order: #323 → #327 → #322 → #324 → #325 → #326. Use merge commits; after the predecessor lands, retarget the next PR to
mainbefore merging.