Repository navigation
Conversation
zyssyz123
requested review from
JohnJyong,
QuantumGhost and
laipz8200
as code owners
October 14, 2026 02:28
2 of 3 tasks
Contributor
Pyrefly Type Coverage
|
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-10-14 02:30:05.174143202 +0000
+++ /tmp/pyrefly_pr.txt 2026-10-14 02:29:54.406079422 +0000
@@ -5801,13 +5801,13 @@
ERROR Argument `dict[str, list[dict[str, dict[str, str | dict[str, str] | dict[str, int | str]]]]]` is not assignable to parameter `graph` with type `dict[str, object] | None` in function `_make_workflow` [bad-argument-type]
--> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:623:67
ERROR Argument `() -> tuple[SimpleNamespace, Generator[NodeRunFailedEvent, Unknown]]` is not assignable to parameter `getter` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase | IterationFrameRequest | LoopFrameRequest]]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService._handle_node_run_result` [bad-argument-type]
- --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1462:16
+ --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1472:16
ERROR Argument `() -> tuple[SimpleNamespace, Generator[object, Unknown]]` is not assignable to parameter `getter` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase | IterationFrameRequest | LoopFrameRequest]]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService._handle_node_run_result` [bad-argument-type]
- --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1866:20
+ --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1877:20
ERROR Argument `() -> tuple[SimpleNamespace, Iterator[NodeRunFailedEvent]]` is not assignable to parameter `getter` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase | IterationFrameRequest | LoopFrameRequest]]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService._handle_node_run_result` [bad-argument-type]
- --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1886:16
+ --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1897:16
ERROR Argument `() -> tuple[SimpleNamespace, Iterator[NodeRunFailedEvent]]` is not assignable to parameter `getter` with type `() -> tuple[Node[Unknown], Generator[GraphNodeEventBase | IterationFrameRequest | LoopFrameRequest]]` in function `services.rag_pipeline.rag_pipeline.RagPipelineService._handle_node_run_result` [bad-argument-type]
- --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1906:16
+ --> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_service.py:1917:16
ERROR No matching overload found for function `typing.MutableMapping.update` called with arguments: (dict[str, object]) [no-matching-overload]
--> tests/unit_tests/services/rag_pipeline/test_rag_pipeline_transform_service.py:29:18
ERROR No matching overload found for function `typing.MutableMapping.update` called with arguments: (dict[str, object]) [no-matching-overload]
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44036 +/- ##
==========================================
- Coverage 88.92% 88.92% -0.01%
==========================================
Files 5327 5327
Lines 328950 328950
Branches 65847 65847
==========================================
- Hits 292532 292530 -2
- Misses 31230 31231 +1
- Partials 5188 5189 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zyssyz123
enabled auto-merge
October 14, 2026 07:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Summary
Refs #43830.
Recognize existing hyphenated node IDs in workflow-aware Prompt parsing, skipped-branch reference warnings, and RAG datasource parameter/input discovery. These paths currently ignore references such as
{{#input-check.text#}}even though the frontend accepts the node ID. Only the node-ID character class is extended; IDs are not renamed and the remaining grammar is unchanged.The Graphon runtime parser fix is langgenius/graphon#340. This PR deliberately leaves the pinned Graphon 0.7.0 dependency unchanged: normal rollout needs a compatible Graphon release/backport followed by a dependency update. It should not trigger an unrelated upgrade to Graphon 0.8.0. The workflow generator's existing ID-generation policy is unchanged.
Validation:
git diff --checkpassed.LLMNode.run()passed the resolvedredandblueinputs to a local capture model adapter, without external model calls.Screenshots
Backend change; representative captured USER prompt:
Please process: {{#input-check.validated_input#}}Please process: redChecklist
make lint && make type-check(backend) andvp staged(frontend) to appease the lint godsNo frontend changes or documentation update required. Targeted backend lint/type checks are listed above; the full repository-wide lint/type commands were not run.
From Codex