Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #45339 +/- ##
==========================================
- Coverage 89.77% 89.77% -0.01%
==========================================
Files 6239 6238 -1
Lines 390902 390774 -128
Branches 79285 79231 -54
==========================================
- Hits 350933 350809 -124
+ Misses 33870 33867 -3
+ Partials 6099 6098 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The e2e containers strict config (
api/tests/e2e_tests/containers/pyrefly.toml) still excludes two files that report zero diagnostics under that config's own preset (strict,min-severity = "warn",python-platform = "linux",infer-with-first-use = true). Keeping them excluded only hides future regressions.Un-excluded (both under
api/tests/e2e_tests/containers/):controllers/console/app/test_conversation_read_timestamp.pyrepositories/test_sqlalchemy_api_workflow_node_execution_repository.pyModifies
api/tests/e2e_tests/containers/pyrefly.toml— 2 deleted lines, no additions. No source or test code changes.Tests
api/.venv/Scripts/pyrefly.exe check --config tests/e2e_tests/containers/pyrefly.toml --use-ignore-files=false --disable-project-excludes-heuristics=trueon the two files above (pyrefly 1.4.0): 0 diagnostics.pyrefly check --config tests/e2e_tests/containers/pyrefly.tomlwas run as well. Its only remaining local diagnostic is a pre-existingmissing-importin an unrelated file (core/human_input_v2/im_provider/test_dingtalk_live.py) whose sdist-only dependency is not installable in this offline sandbox; it is not related to this change and resolves under the CI environment.api/tests/unit_tests/pyrefly.toml, so it touches a different CI job. No test code changed, and the container suites require Docker, so pytest is covered by CI.