Skip to content

test(e2e): stop excluding two container tests from strict pyrefly - #45339

Open
shi-felix wants to merge 2 commits into
langgenius:mainfrom
shi-felix:pyrefly/containers-non-service
Open

shi-felix wants to merge 2 commits into
langgenius:mainfrom
shi-felix:pyrefly/containers-non-service

Conversation

@shi-felix

Copy link
Copy Markdown
Contributor

Summary

The e2e containers strict config (api/tests/e2e_tests/containers/pyrefly.toml) still excludes two files that report zero diagnostics under that config's own preset (strict, min-severity = "warn", python-platform = "linux", infer-with-first-use = true). Keeping them excluded only hides future regressions.

Un-excluded (both under api/tests/e2e_tests/containers/):

  • controllers/console/app/test_conversation_read_timestamp.py
  • repositories/test_sqlalchemy_api_workflow_node_execution_repository.py

Modifies

  • api/tests/e2e_tests/containers/pyrefly.toml — 2 deleted lines, no additions. No source or test code changes.

Tests

  • api/.venv/Scripts/pyrefly.exe check --config tests/e2e_tests/containers/pyrefly.toml --use-ignore-files=false --disable-project-excludes-heuristics=true on the two files above (pyrefly 1.4.0): 0 diagnostics.
  • Project-mode pyrefly check --config tests/e2e_tests/containers/pyrefly.toml was run as well. Its only remaining local diagnostic is a pre-existing missing-import in an unrelated file (core/human_input_v2/im_provider/test_dingtalk_live.py) whose sdist-only dependency is not installable in this offline sandbox; it is not related to this change and resolves under the CI environment.
  • This is the container/e2e config, separate from api/tests/unit_tests/pyrefly.toml, so it touches a different CI job. No test code changed, and the container suites require Docker, so pytest is covered by CI.

@github-actions github-actions Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 2, 2026
@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.77%. Comparing base (5e3edb5) to head (1d66a92).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #45339      +/-   ##
==========================================
- Coverage   89.77%   89.77%   -0.01%     
==========================================
  Files        6239     6238       -1     
  Lines      390902   390774     -128     
  Branches    79285    79231      -54     
==========================================
- Hits       350933   350809     -124     
+ Misses      33870    33867       -3     
+ Partials     6099     6098       -1     
Flag Coverage Δ
api 89.64% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant