Skip to content

modules/niri: escape kdl strings properly - #195

Merged
zimward merged 1 commit into
lassulus:mainfrom
sometreee:niri-proper-escape
Oct 6, 2026
Merged

zimward merged 1 commit into
lassulus:mainfrom
sometreee:niri-proper-escape

Conversation

@Kruemmelspalter

Copy link
Copy Markdown
Contributor

from #193 / #194:

i would assume that the parser would just accept unicode characters and the \u escapes are just there for readabilty?

my suggestion would be

''"'' => ''\"''
''/'' => ''\/''
''\'' => ''\\''
# \b: nix does not have backspace literals (ig they could be read from a file but like. then it's okay for there to be an error
# \f: nix does not have form feed literals either
"\n" => ''\n''
"\r" => ''\r'' # also will probably not occur buy why not
"\t" => ''\t''
# \u: disregard unicode for now and just leave it like it is

cc @zimward

@Kruemmelspalter Kruemmelspalter changed the title niri: escape kdl strings properly modules/niri: escape kdl strings properly Sep 24, 2026

@zimward zimward left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@zimward
zimward merged commit d814b84 into lassulus:main Oct 6, 2026
2 checks passed
@Kruemmelspalter
Kruemmelspalter deleted the niri-proper-escape branch October 13, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants