Repository navigation
Conversation
Patch release with the HEAD pattern-match fix for latest_file_size/1 and the unused Logger require warning fix. No tzdata version bump (still 2026d).
Sham.expect's "was this called" check is recorded via a GenServer call made by the plug process *after* it has already sent the HTTP response, racing against the client (and thus the test, and on_exit) proceeding. Under CI load this occasionally lost the race, failing with "No HTTP HEAD request was received by Sham" even though the request succeeded. Sham.stub has the same callback behavior without that assertion, and each test already asserts on the actual returned value, which only succeeds if the request was genuinely received and handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch release with the HEAD pattern-match fix for latest_file_size/1 and the unused Logger require warning fix. No tzdata version bump (still 2026d).