Conversation
Author
|
I wasn't able to run make test on Windows/Git Bash, because it failed at docker compose up (my Docker setup lacks the Compose v2 plugin). This PR only changes documentation, so it shouldn't affect the tests |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add helper note when cloning the project on windows to avoid auto cr/lf clashes. Although a Windows user may already have their Git set up to NOT switch LF to CR/LF, this simple note may save some developers a few hours of debugging time.
Pipeline: chore
Spec:
Gates:
Deploy-impact: none -- just a handy note for anyone cloning on Windows was added
Summary
Adds a note for developers cloning to a Windows box. Although the developers may already have Git set up to NOT convert linefeeds to cr/linefeeds, there may be times when that is not the case. Adding just this simple extra note may save them several hours of debugging.
Closes #
Changes
Type of Change
Checklist
make testpasses (unit + integration + functional — CI does not run functional) (NOTE: I CANNOT RUN THE MAKE COMMANDS YET DUE TO WINDOWS DOCKER ISSUES THAT I AM WORKING ON IN ANOTHER BRANCH. )make stanpasses (PHPStan level 8 oversrc)make cs-fixerapplied and left the worktree unchangedFactory gates
Gates:line aboveScreenshots (if applicable)