Conversation
Contributor
Author
|
/rerun red |
Contributor
Author
|
@uncleDecart could you please restart the tests here? |
europaul
force-pushed
the
json-instead-of-protojson
branch
from
September 18, 2025 17:03
123c3a3 to
83a9c34
Compare
eriknordmark
requested changes
Sep 29, 2026
eriknordmark
left a comment
eriknordmark
left a comment
Contributor
There was a problem hiding this comment.
Please rebase this on master.
I was wondering for a long time why msgid is marshalled as a string, while it's defined as int64. Turns out that protojson.Marshal converts all int64 to string according to the protobuf spec. I find this peculiar, so I decided to use json.Marshal instead. We'll only use this for printing, to avoid compatibility issues. Signed-off-by: Paul Gaiduk <paulg@zededa.com>
europaul
force-pushed
the
json-instead-of-protojson
branch
from
September 30, 2026 16:58
83a9c34 to
3438dec
Compare
Contributor
Author
|
Closing: json.Marshal changes the output shape for proto messages (oneofs nest as {"MetricContent":{"Dm":...}}, timestamps become {seconds,nanos}), which breaks existing jq-based test scripts. protojson's int64-as-string is the lesser evil. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was wondering for a long time why msgid is marshalled as a string, while it's defined as int64. Turns out that protojson.Marshal converts all int64 to string according to the protobuf spec.
I find this peculiar, so I decided to use json.Marshal instead. We'll only use this for printing, to avoid compatibility issues.
As can be seen here it's a known issue and is by design.