Use relative debug altlink in test binary - #1671
Merged
Merged
Conversation
One of the debug altlink tests broke on Mac OS and Windows in CI. The reason being that the corresponding CI jobs use out-of-band produced test artifacts, which are implicitly assumed to be "relocatable". That's violated with out debug altlink artifacts, which currently embed absolute paths. Switch over to using relative ones to fix this problem. Signed-off-by: Daniel Müller <deso@posteo.net>
d-e-s-o
enabled auto-merge (rebase)
September 22, 2026 20:11
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1671 +/- ##
==========================================
+ Coverage 95.20% 95.24% +0.04%
==========================================
Files 58 58
Lines 11293 11291 -2
==========================================
+ Hits 10751 10754 +3
+ Misses 542 537 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the debug altlink tests broke on Mac OS and Windows in CI. The reason being that the corresponding CI jobs use out-of-band produced test artifacts, which are implicitly assumed to be "relocatable". That's violated with out debug altlink artifacts, which currently embed absolute paths.
Switch over to using relative ones to fix this problem.