Don't panic on debug altlink target without build ID - #1672
Merged
Merged
Conversation
try_deref_debug_altlink() verifies the build ID of a debug altlink destination against the one recorded in the .gnu_debugaltlink section, but it reads the former with an unwrap(). A destination lacking a NT_GNU_BUILD_ID note, hence, causes a panic. Report an error instead and add a test covering the case. Signed-off-by: Daniel Müller <deso@posteo.net>
d-e-s-o
enabled auto-merge (rebase)
September 22, 2026 21:13
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1672 +/- ##
==========================================
- Coverage 95.23% 95.23% -0.01%
==========================================
Files 58 58
Lines 11291 11305 +14
==========================================
+ Hits 10753 10766 +13
- Misses 538 539 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try_deref_debug_altlink() verifies the build ID of a debug altlink destination against the one recorded in the .gnu_debugaltlink section, but it reads the former with an unwrap(). A destination lacking a NT_GNU_BUILD_ID note, hence, causes a panic.
Report an error instead and add a test covering the case.