Honor all debug directories in build ID based lookup - #1673
Merged
Merged
Conversation
DebugFileIter hard codes its build ID based candidate to /usr/lib/debug/.build-id, ignoring the debug directories it is handed entirely. A directory configured via Builder::set_debug_dirs(), hence, never has its .build-id sub-directory consulted, which contradicts the documented promise that a provided list overwrites the defaults. gdb, for comparison, appends /.build-id/ to each debug-file-directory entry. Adjust the iterator to search .build-id/ sub-directories of all debug dirs instead. Signed-off-by: Daniel Müller <deso@posteo.net>
d-e-s-o
enabled auto-merge (rebase)
September 22, 2026 21:50
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1673 +/- ##
=======================================
Coverage 95.20% 95.21%
=======================================
Files 58 58
Lines 11305 11341 +36
=======================================
+ Hits 10763 10798 +35
- Misses 542 543 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DebugFileIter hard codes its build ID based candidate to /usr/lib/debug/.build-id, ignoring the debug directories it is handed entirely. A directory configured via Builder::set_debug_dirs(), hence, never has its .build-id sub-directory consulted, which contradicts the documented promise that a provided list overwrites the defaults. gdb, for comparison, appends /.build-id/ to each debug-file-directory entry.
Adjust the iterator to search .build-id/ sub-directories of all debug dirs instead.