feat(codex): prepare Codex Spark retirement and remove its quota UI - #4334
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 61 / 80설명 지금 코드를 보면 대략 네 묶음입니다. (1) 어댑터 쪽에서는 docs-site 여러 언어와 라인 - 이게 무슨 문제다 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
Carries the test-only fixture changes from lidge-jun#4334 (622372f), and completes native path expectations for Devin CLI credential lookup. Co-authored-by: JUN <bitkyc08@gmail.com>
Carries the test-only fixture changes from lidge-jun#4334 (622372f), and completes native path expectations for Devin CLI credential lookup. Co-authored-by: JUN <bitkyc08@gmail.com>
622372f to
2b976c9
Compare
The retirement branch was cut ~300 commits behind dev, so the Spark surfaces it removes had been extended in the meantime. Conflicts are resolved in favor of removing Spark while keeping the unrelated work that landed alongside it: - openai-responses: drop the Spark Lite body-shape override and the bodyCarriesLiteToolShape helper it was the only caller of. - codex/quota: keep the retirement tombstone and predicate, drop the WHAM Spark window parsing and the Spark header merge, and carry dev's new pool quota history evidence argument through the header path. historyWindows no longer emits a spark family, since no observation path can produce one; the family stays in the history schema so older persisted samples still parse. - structure docs: keep both sides' notes, and remove the Spark Lite contract paragraph that documented the behavior this branch deletes. - tests: retarget the scoped-lane routing cases to the surviving reserve scope, generalize the Lite identity and bracket-normalization cases, and align the quota parity expectations with a retired refresh being inert.
|
Maintainer integration record — final pull request of the batch, merged by @lidge-jun. #4334 retires Codex Spark across 34 core files and was deliberately held until last. It collides with almost every other lane in this batch, so rebasing it once against a fully landed
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
opencodex/structure/transports/responses.md
Lines 433 to 435 in 80a4278
Update the public Spark forwarding documentation
This correctly records that the model-specific Lite override was removed, but docs-site/src/content/docs/reference/architecture.md:160-167 and its translated counterparts still tell users that Spark requests and aliases force the Lite header from the body shape. After this change, a user diagnosing a manually supplied legacy Spark request will be instructed to expect behavior the adapter no longer performs. Update or remove that section in the English architecture page and synchronized locales.
AGENTS.md reference: AGENTS.md:L380-L381
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
Hold for retirement — DO NOT MERGE. Tibo's September 11 announcement says GPT-5.3-Codex-Spark retires “next week”; no exact date/time was given. This draft prepares removal and leaves the current service and integration branches unchanged.
Remove Spark from Codex-login model discovery, restored catalogs and dedicated request compatibility. Remove its quota scope, collection, settings endpoint field and account-card UI. Old Spark-only quota becomes unknown rather than shared capacity, and stale model/quota observations cannot revive it. Shared/Reserve isolation, generic Lite/tools/custom windows, historical costs and other providers' Muse Spark remain intact.
Related: #4130 fixes Spark Lite while Spark is available. This draft neither carries nor closes it.
Verification
--no-verify.2b976c96(run 34693477839). The previous head622372f79was fully green (26/26 jobs, run 34673706298) before this rebase.08717a046c2b2550c8ed08499511e5edc6aa2801, synthetic fixture API only. Desktop/mobile visually inspected; refresh, pause-exhausted and resume verified. Fixture server stopped and port closed.devafter fix(devin-cli): honor platform path semantics in credential discovery #4400 landed the same pnpm/Devin fixture portability fix plus the productionsrc/oauth/devin-cli.tschange; the now-redundant tests-only commit was dropped and thesrc/codex/routing.tsimport andcodex-quota-parser-paritydescribe block were merged with the quota-avoidance work from fix(codex): apply a quota refusal's avoidance window to the main login #4396/fix(codex): let clear-cooldown lift an avoidance the cooldown outlived #4397.Mobile screenshot · Screenshot provenance
Checklist