feat: restore opt-in plaintext V2 agent messages - #4351
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (130)
📝 WalkthroughWalkthroughThis change set updates Responses reasoning presentation, canonical transport policies, Spark Lite signaling, combo normalization, plaintext v2 agent messages, Console upload recovery, configuration validation, tests, and documentation. It also records related planning and verification status. ChangesResponses contracts and transport behavior
Estimated code review effort: 5 (Critical) | ~120 minutes ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Eran <earan@localhost> Co-authored-by: yxr1995-maker <257504378+yxr1995-maker@users.noreply.github.com>
Contributor
|
✅ Deterministic PR hygiene checks passed. |
3 tasks
Co-authored-by: Wonchang Oh <itismyfield@gmail.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Codex <codex@localhost>
Co-authored-by: Robin Bially <7304732+RobinBially@users.noreply.github.com> Co-authored-by: yxr1995-maker <257504378+yxr1995-maker@users.noreply.github.com> Co-authored-by: Eran <earan@localhost>
Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com>
Owner
Author
리뷰 · 우선순위 46 / 80이 PR은 설정 전용 opt-in·canonical ChatGPT·responses wire·catalog에 spawn_agent가 있을 때만 준비하는 가드가 있다. JSON/SSE/WS 복원은 malformed·충돌·over-limit을 재시도 없이 거절한다. 문서에 plaintext 보존을 드러낸다고 한다. 정적 보안 PASS 언급은 있으나 라이브 백엔드 canary는 없다. types/config를 만지므로 split 캠페인과 파일 충돌 위험이 있고, 실험적 프로토콜 변환이라 실수 시 툴 라우팅이 깨진다. 경로/심볼 - 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
Document reasoningEffortMode in all seven translated guides. Keep the original Chat-wire regression; Responses summary is not a Chat request field.
Resolve structure/ doc conflicts by keeping both the combos reasoning-preservation notes and the dev service_tier echo contract.
Keep both the Console upload-rejection exclusion note and the inherited responses-transport contract paragraphs.
Keep both the raw-reasoning presentation note and the combo effort-normalization note in the Cursor provider doc.
All conflicts were add/add doc paragraphs from the hint and thinking lanes at the same anchor; both notes are retained.
Add/add doc conflicts keep both the Spark Lite metadata note and the inherited transport-hint and summary contracts.
Brings origin/dev and the five lower lane branches (models-reasoning, stream-console, thinking, thinking-hints, thinking-spark) onto the stack tip. Conflict resolutions in src/server/responses/core.ts: - imports and adapter-request state keep both the plaintext-V2 alias tracking and dev's Meta Muse tool-name aliases; they are independent features. - the alias refresher keeps this branch's renamed refreshRequestToolAliases (every call site outside the conflict already uses it) and also refreshes routedMuseToolNameAliases. - the recovery rebuild keeps stream-console's console-go-upload-retry guard so that retry does not rebuild the request, with the renamed refresher call. - route normalization keeps both the plaintext-V2 preparation and the provider summary recompute. Doc and layout conflicts were add/add paragraphs or map entries from the separate lanes; both sides are retained and the layout maps stay sorted.
Contributor
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
Keeps both the plaintext-V2 scoping note and the new standalone audio transcription section in structure/data-planes/inbound-compat.md.
Owner
Author
|
Maintainer integration record — responses lane tip, merged by @lidge-jun. This is the tip of the cumulative responses stack, so merging it with a merge commit lands the whole lane and lets GitHub close each link with the correct
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
lidge-jun
added a commit
that referenced
this pull request
Sep 13, 2026
Keep current origin/dev subagent/V2 contracts and retain the quota-history publication identity pointer.
lidge-jun
added a commit
that referenced
this pull request
Sep 13, 2026
Keep current origin/dev V2/thinking contracts and retain bounded quota-observation pointers.
lidge-jun
added a commit
that referenced
this pull request
Sep 13, 2026
Keep current origin/dev V2/thinking contracts and retain plan-exclusion coverage.
lidge-jun
added a commit
that referenced
this pull request
Sep 13, 2026
Keep current origin/dev V2/thinking contracts and retain reset-first ordering.
lidge-jun
added a commit
that referenced
this pull request
Sep 13, 2026
Keep current origin/dev V2/thinking/stream contracts, retain usage incomplete-history disclosure, and keep the GUI screenshots already attached for #4357.
This was referenced Sep 13, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the configuration-only
plaintextV2AgentMessagesoption from #2496 on current dev. Explicit opt-in rewrites eligible canonical ChatGPT V2 namespace and message-tool identities and restores them before client delivery and continuation storage. JSON, SSE and WebSocket restoration reject malformed, conflicting and over-limit payloads without retrying the model.Relates to #2495. This is a maintainer-owned adaptation of #2496 at
1a4cb4aab14200ec2efa71aea00d2a55fc90aca7. #4242/#4243 were reviewed as alternatives; their different flag, mirror behavior and management surface are not carried. Encrypted multipart recovery in #3661 is separate.Verification
git diff --check: passed. Static import-path inspection found no missing imports in the two new test files; this is not runtime verification.4db9d98f084a93297fe26e85002e15ecb2dbdaaf: Cross-platform CI, fulllane=all, failure (Windows Devin/pnpm/client-connect fixtures; all other jobs succeeded). Earlier heads are not verification evidence.Checklist
Co-authored-by: Sigurd gliao2@ur.rochester.edu
Resume evidence: nullable namespace correction
bda46fe8f0received independent static security PASS. The previous full CI at4319c1eae0failed Windows Devin/pnpm/autostart fixtures; it is not a green baseline. Other lanes retain their source fixes. Current full CI has failed; no merge or completed acceptance is claimed.Final full-run disposition: Windows 3 failed the models-owned Devin discovery fixture; Windows 4 failed two Combo-owned pnpm fixtures; Windows 5 failed a client-connect probe timeout. Other-lane files remain untouched; no flake or green-baseline claim. Parent integration must resolve the recorded test-layout JSON conflicts and coordinate remaining repairs.
Stacked-lane GUI change and screenshot
This branch is the tip of the responses/core stack, so its diff against
devalso carries theLogs recovery-label change from #4354 (
gui/src/pages/Logs.tsxplus ninegui/src/i18n/*entries). The visible effect is one new attempt-recovery reason, "Console upload retry", in the
Logs request-detail panel. Screenshot of that label, reused from #4354:
Stack refresh:
origin/dev(afe987cff) and the five lower lane branches are merged into thistip;
bun run typecheck,bun run structure:checkandbun run privacy:scanpass locally.Summary by CodeRabbit
New Features
Documentation
Bug Fixes