docs(devlog): record the 2.58.0 release evidence - #4918
Conversation
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release plan documents the 2.58.0 release sequence, three operational lessons, the shipped native control stack contract, remaining activation conditions, and registry propagation status. ChangesRelease train documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
리뷰 · 우선순위 77 / 80이 PR은 지금 문서가 말하는 순서는 현재 저장소와 맞습니다. 프리즈 후보 본문에 적힌 세 가지 교훈(초록 PR ≠ 초록 머지 결과, 오래된 ref dispatch는 그 ref의 CI 정의를 탄다, 스택 자식 rebase가 머지 커밋 안쪽만의 변경을 조용히 버림)과 네이티브 컨트롤 스택 기본-off·활성화 전 조건 세 줄은, 이번 열차에서 실제로 시간을 잡아먹은 이야기와 맞습니다. npm 전파가 아직 pending일 수 있으니 재발행하지 말라는 경고도 출시 직후 문서에 어울립니다. 라인 표 — 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78424292eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Published. 2.58.0 is on `main` and `preview`, tag `v2.58.0` names the release commit, the GitHub | ||
| release exists, and `npm publish` returned success with a signed provenance statement. Registry | ||
| propagation is tracked at the end. |
There was a problem hiding this comment.
Move the completed release train to
_fin
This entry declares the release published and the commit closes the train, but the unit remains under _plan and its roadmap still says Open. That misclassifies completed work as active; record any final registry result, update the status, and move the whole 260918_2580_release_train directory to devlog/_fin/.
AGENTS.md reference: AGENTS.md:L102-L105
Useful? React with 👍 / 👎.
Summary
Records what the 2.58.0 release actually did, step by step, with the run ids and commits that prove each step. Closes the train unit opened in #4909.
It also writes down three things this release taught, because each one cost real time and none of them is obvious from the code: a green pull request is not a green merge result when two branches touch the same capped file, dispatching a stale ref runs that ref's CI definition rather than the current one, and rebasing a stacked child silently drops anything that lived only inside its merge commits.
The native control stack section states what shipped behind default-off flags and the three conditions that remain before recommending activation.
Documentation only: one new file under
devlog/_plan/260918_2580_release_train/.Verification
Hosted CI on this head. The heavy legs are filtered out by the
changesjob because the diff is documentation only.Every claim in the document names its evidence — run ids, commit SHAs, the publish line, and the transparency-log index — so the file can be checked against the repository and the Actions history rather than taken on trust.
No local suite, typecheck, build, or install was run.
Checklist
Summary by CodeRabbit