Skip to content

docs(i18n): apply the QA review notes to the translation guide (JUMEMB-137) - #905

Merged
chybisov merged 1 commit into
mainfrom
feature/jumemb-137-apply-the-qa-review-notes-to-the-translation-guide
Oct 9, 2026
Merged

chybisov merged 1 commit into
mainfrom
feature/jumemb-137-apply-the-qa-review-notes-to-the-translation-guide

Conversation

@chybisov

@chybisov chybisov commented Oct 9, 2026

Copy link
Copy Markdown
Member

Which Linear task is linked to this PR?

JUMEMB-137

What this PR does

This PR applies the notes of the Zeus QA review (jumperexchange/jumper-frontend#3304 and #3305) to the shared translation guide. The four repos keep the same guide and glossaries:

  • TRANSLATING.md:
    • It removes "We do not use Crowdin." No Crowdin text remains.
    • It adds a precedence rule: if an existing text uses another word than the glossary, follow the glossary.
  • docs/i18n/th.md: it removes a stale claim. No Thai text ends with a period now.
  • docs/i18n/fr.md: the "gaz" note now agrees with its evidence (MetaMask, Ledger Live and OKX write "gaz").
  • docs/i18n/uk.md and vi.md: the register line now gives the reason, not only one word.

The same change is in jumperexchange/jumper-frontend#3305, jumperexchange/jumper-widget, lifinance/widget and lifinance/explorer.

Why was it implemented this way?

The four repos share one guide. A fix in one repo only makes the guides drift apart. This PR changes only these 6 lines. It does not render the files again.

Visual showcase (Screenshots or Videos)

Not applicable. This PR changes only docs.

Checklist before requesting a review

  • I have performed a self-review and testing of my code.
  • This pull request is focused and addresses a single problem.

@changeset-bot

changeset-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ecd7a88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chybisov
chybisov marked this pull request as ready for review October 9, 2026 14:25
@chybisov
chybisov merged commit feefb49 into main Oct 9, 2026
5 checks passed
@chybisov
chybisov deleted the feature/jumemb-137-apply-the-qa-review-notes-to-the-translation-guide branch October 9, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant