Repository navigation
docs(i18n): apply the QA review notes to the translation guide (JUMEMB-137) - #905
Merged
chybisov merged 1 commit intoOct 9, 2026
Conversation
|
chybisov
marked this pull request as ready for review
October 9, 2026 14:25
chybisov
deleted the
feature/jumemb-137-apply-the-qa-review-notes-to-the-translation-guide
branch
October 9, 2026 14:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task is linked to this PR?
JUMEMB-137
What this PR does
This PR applies the notes of the Zeus QA review (jumperexchange/jumper-frontend#3304 and #3305) to the shared translation guide. The four repos keep the same guide and glossaries:
TRANSLATING.md:docs/i18n/th.md: it removes a stale claim. No Thai text ends with a period now.docs/i18n/fr.md: the "gaz" note now agrees with its evidence (MetaMask, Ledger Live and OKX write "gaz").docs/i18n/uk.mdandvi.md: the register line now gives the reason, not only one word.The same change is in jumperexchange/jumper-frontend#3305, jumperexchange/jumper-widget, lifinance/widget and lifinance/explorer.
Why was it implemented this way?
The four repos share one guide. A fix in one repo only makes the guides drift apart. This PR changes only these 6 lines. It does not render the files again.
Visual showcase (Screenshots or Videos)
Not applicable. This PR changes only docs.
Checklist before requesting a review