Repository navigation
fix: accept empty sourceCursor placeholders in 1.0.3-2 - #102
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Ordinary searches containing
sourceCursor: ""failed withE_SOURCE_CURSOR_MODEbefore the search engine ran. Remove that empty placeholder outside inspection mode at the shared request normalization boundary and disclose the change in text anddetails.requestNotes. Pi, OMP and MCP use the same boundary. Prepare version 1.0.3-2 and regenerate shipped artifacts.Fixes #101.
Validation
bun run checkbun run pack:checkbun run check:local: 525 passed, 0 failed, 3 conditionally skipped; Node HTTP/stdio smoke and benchmark passed.Compatibility and risks
Only an exactly empty
sourceCursoroutsidemode=inspectis treated as omitted. Other fields are preserved, nonempty tokens still require inspection mode, and no schema type or mode restriction is relaxed. The source of the placeholder in the reporter's real model session remains unproven; these tests inject the reported shape and use actual search execution. The three skipped tests cover optional concept inference and a platform-specific non-UTF-8 path case; this change does not alter those implementations.Rollback: revert this focused change on main and release a new patch; do not replace the immutable npm version.
Documentation
AI assistance
Implemented and reviewed with OpenAI Codex (GPT-6 family). The AI executed the checks listed above and reviewed the final source and generated diff. No separate human review has been recorded. Public CI results are separate from the local test evidence.