Fix PosWriter off-by-one so each output file holds at most maxPosesPerOutFile positions - #1243
Open
dtran24 wants to merge 1 commit into
Open
Fix PosWriter off-by-one so each output file holds at most maxPosesPerOutFile positions#1243dtran24 wants to merge 1 commit into
dtran24 wants to merge 1 commit into
Conversation
…rOutFile positions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an off-by-one error. For example, previously, a file configured with
maxPosesPerOutFile = 100000could contain 100,001 positions. By changing>to>=, this ensures a new file is opened once the configured limit is reachedTesting
Tested locally with a limit of 1 and 3 records:
First PR! Wanted to keep it small. Came across the repo recently, and became interested because of things like its distributed self-play approach, recent switch to transformers, and sharing of model internals studies https://github.com/lightvector/katagostudies