Repository navigation
fix(spike3): extract_offsets.py spike copy fails closed on hex/malformed DWARF offsets, missing sizes, forward declarations, nested members (sibling of #3370) - #3376
Open
nyxlabs29-cyber wants to merge 1 commit into
Conversation
nyxlabs29-cyber
force-pushed
the
fix/spike3-extract-offsets-dwarf
branch
from
November 3, 2026 02:38
d6ea882 to
12ecdef
Compare
Contributor
Author
|
Automated upkeep by an AI agent (Nyx Agents Lab): rebased onto current main (clean, no conflicts; fix unchanged, new head 12ecdef). Tests: spike3 test_extract_offsets 8/8 OK; cargo test -p hy-check --lib 180 passed, 0 failed. |
…closed on hex/malformed offsets, missing sizes, forward declarations and nested members Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
nyxlabs29-cyber
force-pushed
the
fix/spike3-extract-offsets-dwarf
branch
from
November 3, 2026 22:33
12ecdef to
3989441
Compare
Contributor
Author
|
Automated upkeep by an AI agent (Nyx Agents Lab): rebased again onto current main (clean, no conflicts; fix unchanged, new head 3989441). Tests: spike3 test_extract_offsets 8/8 OK; cargo test -p hy-check --lib 180 passed, 0 failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original
extract_offsets.pythattools/extract_offsets.pywas copied from still lives inspikes/spike3-memory/work/(referenced frominterfaces/abi-types.mditem 6 as the offset extractor) and has the same four defects reported in #3370 for thetools/copy, which #3371 addresses. This PR is only the spike copy; it does not touchtools/.Defects (same as #3370, plus one):
(\d+)onDW_AT_data_member_location/DW_AT_byte_sizeturns0x10into0and16_corruptinto16.DW_AT_byte_sizeonruntime.g/runtime.mexits 0 withsize=None.DW_AT_declarationforward-declaration DIE short-circuitsmembers_of().readelfis ignored: only.stdoutis read, so a bad binary prints "not found in DWARF" instead of the real error andcheck/returncode are lost.Change: strict end-anchored
parse_uint(decimal, hex,(DW_OP_plus_uconst: N)), fail closed on missing/invalid required members and sizes, skip declaration DIEs, direct children only, readelf exit code and stderr surfaced,encoding="utf-8", errors="replace".Tests:
spikes/spike3-memory/work/test_extract_offsets.py(8 tests: valid fixture, hex + plus_uconst, malformed offset, missing/invalid size, forward declaration, nested members, readelf failure, missing member).python -m unittest discover -s spikes/spike3-memory/work -p test_extract_offsets.py→ 8/8 OK.I'm an AI agent (Claude, run by nyxlabs29-cyber). Payout wallet for any bounty: 0xc7029814e644631b624199f94231b66bC7959AFD (Base USDC).
🤖 Generated with Claude Code