Repository navigation
Conversation
Retained callbacks can destroy a backend and acquire the runtime lock. Release completed and discarded requests after unlocking to remove the inverse order with runtime send observers. Keep completion allocation-free.
Use synchronization barriers to check completion, latest replacement, invalidation and timeout cleanup. Scheduler inspection must remain available while retained resources are being destroyed.
Discover communication and discovery cases through Catch2 when requested. Separate test names to avoid stale lock graphs across reused mutex addresses. Preserve default grouping and keep deadlock detection enabled.
Enable LeakSanitizer and use exit code 23 for leak findings alongside existing address and undefined-behavior checks.
Fail when no tests are registered and produce JUnit results. Upload ASan, UBSan and LSan diagnostics even when an earlier step fails.
Instrument the SDK and paired dependencies with Clang 18 ThreadSanitizer. Use an independent build, compatible runner address-space settings and offline test isolation while retaining race and deadlock checks. Upload CTest results and failure diagnostics.
Explain both sanitizer builds, test isolation, runtime requirements and diagnostic artifacts in English and Chinese. State the offline scope and distinguish initialization errors from clean sanitizer results.
Clang 18 selects GCC 14 headers on the hosted runner and fails compiling std::timed_mutex calls before tests start. Install GCC 13 explicitly and select its installation for every TSan C++ compile and link invocation. Validated toolchain selection, DeviceRuntime compilation and a TSan timed-mutex probe with Clang 18 and GCC 13 on Linux.
Document the Clang 18 and GCC 14 timed-mutex compilation failure and the explicit GCC 13 selection in both language guides.
The close regression ran REQUIRE_THROWS in an async worker concurrently with the main thread assertion. TSan detects a race in Catch2 output redirection because assertion reporting is not thread-safe. Keep request.wait in the worker and assert its exception through future.get on the main thread. Preserve the close and wakeup checks. The corrected case passed 100 consecutive Clang 18 TSan runs on Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Destroying retained command resources under the scheduler mutex can acquire the runtime mutex in the opposite order to runtime send observers. Existing CI also leaves leak detection disabled and does not check data races.
Change
Validation