Skip to content

Fix capability lookup across equivalent semantic values - #8

Draft
zhuzx17 wants to merge 3 commits into
mainfrom
copilot/fix-github-actions-job-failure
Draft

zhuzx17 wants to merge 3 commits into
mainfrom
copilot/fix-github-actions-job-failure

Conversation

@zhuzx17

@zhuzx17 zhuzx17 commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

The ROS Humble compatibility job could crash while constructing snapshots because capability lookups used enum identity, which can differ across separately loaded modules or value wrappers.

  • Capability lookup: Compare TelemetrySemantic and CommandSemantic values with == instead of is.
  • Regression coverage: Add a focused test confirming capability lookups accept equivalent string semantics.
  • Scope: Preserves existing enum-based lookups while making them compatible with equivalent semantic values.
assert capabilities.telemetry_channel(TelemetrySemantic.ANGLES) is not None
assert capabilities.telemetry_channel("angles") is not None

zhuzx17 and others added 2 commits November 20, 2026 10:41
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@zhuzx17 zhuzx17 changed the title [WIP] Fix failing GitHub Actions job Latest ROS compatibility (humble) Fix capability lookup across equivalent semantic values Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants