Skip to content

Feat: adding flexible placement group limit - #1038

Open
avnimish wants to merge 2 commits into
linode:mainfrom
avnimish:feat/adding-flexible-placement-group-limit
Open

Feat: adding flexible placement group limit#1038
avnimish wants to merge 2 commits into
linode:mainfrom
avnimish:feat/adding-flexible-placement-group-limit

Conversation

@avnimish

Copy link
Copy Markdown

📝 Description

This change adds the flexible placement group limit as a field in the PlacementGroupLimits to use when provisioning Placement groups

✔️ How to Test

make TEST_ARGS=-run=TestRegions_pgLimits test-int

Copilot AI lite review requested due to automatic review settings August 31, 2026 17:41
@avnimish
avnimish requested review from a team as code owners August 31, 2026 17:41
@avnimish
avnimish requested review from psnoch-akamai and zliang-akamai and removed request for a team August 31, 2026 17:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request extends the RegionPlacementGroupLimits model in the root linodego API client to surface the API’s “flexible placement group” Linode limit returned by the Regions endpoints, and updates unit/integration tests and fixtures accordingly.

Changes:

  • Added MaximumLinodesPerFlexiblePG to RegionPlacementGroupLimits with the corresponding JSON field mapping.
  • Updated unit fixtures and unit tests to validate the new field is populated.
  • Updated the integration TestRegions_pgLimits to assert the new limit is non-zero.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
regions.go Adds MaximumLinodesPerFlexiblePG to RegionPlacementGroupLimits for Regions API responses.
test/unit/region_test.go Extends unit assertions to validate MaximumLinodesPerFlexiblePG is present and > 0 when limits exist.
test/unit/fixtures/regions_list.json Updates the regions list fixture to include maximum_linodes_per_flexible_pg.
test/unit/fixtures/region_get.json Updates the region get fixture to include maximum_linodes_per_flexible_pg.
test/integration/regions_test.go Extends the placement-group limits integration test to assert MaximumLinodesPerFlexiblePG is non-zero.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants