Feat: adding flexible placement group limit - #1038
Open
avnimish wants to merge 2 commits into
Open
Conversation
avnimish
requested review from
psnoch-akamai and
zliang-akamai
and removed request for
a team
August 31, 2026 17:41
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request extends the RegionPlacementGroupLimits model in the root linodego API client to surface the API’s “flexible placement group” Linode limit returned by the Regions endpoints, and updates unit/integration tests and fixtures accordingly.
Changes:
- Added
MaximumLinodesPerFlexiblePGtoRegionPlacementGroupLimitswith the corresponding JSON field mapping. - Updated unit fixtures and unit tests to validate the new field is populated.
- Updated the integration
TestRegions_pgLimitsto assert the new limit is non-zero.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
regions.go |
Adds MaximumLinodesPerFlexiblePG to RegionPlacementGroupLimits for Regions API responses. |
test/unit/region_test.go |
Extends unit assertions to validate MaximumLinodesPerFlexiblePG is present and > 0 when limits exist. |
test/unit/fixtures/regions_list.json |
Updates the regions list fixture to include maximum_linodes_per_flexible_pg. |
test/unit/fixtures/region_get.json |
Updates the region get fixture to include maximum_linodes_per_flexible_pg. |
test/integration/regions_test.go |
Extends the placement-group limits integration test to assert MaximumLinodesPerFlexiblePG is non-zero. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This change adds the flexible placement group limit as a field in the PlacementGroupLimits to use when provisioning Placement groups
✔️ How to Test