solidigm: fix unchecked return value in ilog_dump_pel() - #3972
Open
sahmed-ibm wants to merge 1 commit into
Open
Conversation
The ilog_dump_pel() function calls nvme_get_log_persistent_event() with NVME_PEVENT_LOG_RELEASE_CTX as the final step to release the persistent event log context on the device. The return value of this call was not checked. If the release call fails, the device-side context is left open. Any subsequent attempt to establish a new context may fail or behave unexpectedly. Use a goto to ensure the release call is always reached and its return value is captured and returned to the caller. Signed-off-by: Sarah Ahmed <sarah.ahmed@ibm.com>
igaw
reviewed
Sep 7, 2026
| @@ -819,16 +808,18 @@ static int ilog_dump_pel(struct libnvme_transport_handle *hdl, struct ilog *ilog | |||
| err = nvme_get_log_persistent_event(hdl, NVME_PEVENT_LOG_READ, | |||
| pevent_log_full, lp.buffer_size); | |||
| if (err) | |||
| return err; | |||
| goto out; | |||
Collaborator
There was a problem hiding this comment.
Is this necessary because the err label just does a return err?
igaw
reviewed
Sep 7, 2026
|
|
||
| ilog->count++; | ||
|
|
||
| err = log_save(&lp, ilog->cfg->out_dir, "log_pages", "lid_0x0d_lsp_0x00_lsi_0x0000.bin", | ||
| pevent_log_full, lp.buffer_size); | ||
| if (err) | ||
| goto out; |
Collaborator
There was a problem hiding this comment.
Same here, can't this just be a return err?
igaw
reviewed
Sep 7, 2026
| nvme_get_log_persistent_event(hdl, NVME_PEVENT_LOG_RELEASE_CTX, | ||
| pevent, sizeof(*pevent)); | ||
|
|
||
| err = nvme_get_log_persistent_event(hdl, NVME_PEVENT_LOG_RELEASE_CTX, |
Collaborator
There was a problem hiding this comment.
And this could be just return nvme_get_log_persistentent_event, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ilog_dump_pel() function calls nvme_get_log_persistent_event() with NVME_PEVENT_LOG_RELEASE_CTX as the final step to release the persistent event log context on the device. The return value of this call was not checked.
If the release call fails, the device-side context is left open. Any subsequent attempt to establish a new context may fail or behave unexpectedly.
Use a goto to ensure the release call is always reached and its return value is captured and returned to the caller.