Skip to content

chore: update libdde-shell-dev version requirement in control - #795

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-tag
Aug 12, 2026
Merged

chore: update libdde-shell-dev version requirement in control#795
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-tag

Conversation

@wjyrich

@wjyrich wjyrich commented Aug 12, 2026

Copy link
Copy Markdown
Contributor
  1. Adjust Version constraint for libdde-shell-dev from >= 2.0.53 to >> 2.0.52 in debian/control build-dependencies
  2. Align the dependency specification with the minimum viable version used at build time
  3. Remove unnecessary upper-bound version requirement to prevent conflicts with newer available releases

Log: No user-facing changes; this is a packaging configuration update only.

Influence:

  1. Build the package in a clean environment to confirm dependencies resolve correctly
  2. Verify that the package links against the intended libdde-shell version at runtime

chore: 更新控制文件中 libdde-shell-dev 版本要求

  1. 将 debian/control 构建依赖中 libdde-shell-dev 的版本约束从 >= 2.0.53 调整为 >> 2.0.52
  2. 使依赖说明与构建时使用的最低可行版本保持一致
  3. 移除不必要的上限版本要求,避免与更新的可用版本产生冲突

Log: 无用户可见变更;仅为打包配置更新。

Influence:

  1. 在干净环境中构建软件包,确认依赖解析正确
  2. 验证软件包运行时链接到的 libdde-shell 版本符合预期

Summary by Sourcery

Relax libdde-shell-dev build dependency version constraints in debian packaging to match the minimum required version and avoid conflicts with newer releases.

Build:

  • Update debian/control to require libdde-shell-dev versions greater than 2.0.52 instead of a specific minimum of 2.0.53 for build-dependencies.

Chores:

  • Align packaging dependency metadata with the actual minimum viable libdde-shell-dev version used at build time.

1. Adjust Version constraint for libdde-shell-dev from `>= 2.0.53` to
`>> 2.0.52` in debian/control build-dependencies
2. Align the dependency specification with the minimum viable version
used at build time
3. Remove unnecessary upper-bound version requirement to prevent
conflicts with newer available releases

Log: No user-facing changes; this is a packaging configuration update
only.

Influence:
1. Build the package in a clean environment to confirm dependencies
resolve correctly
2. Verify that the package links against the intended libdde-shell
version at runtime

chore: 更新控制文件中 libdde-shell-dev 版本要求

1. 将 debian/control 构建依赖中 libdde-shell-dev 的版本约束从 `>=
2.0.53` 调整为 `>> 2.0.52`
2. 使依赖说明与构建时使用的最低可行版本保持一致
3. 移除不必要的上限版本要求,避免与更新的可用版本产生冲突

Log: 无用户可见变更;仅为打包配置更新。

Influence:
1. 在干净环境中构建软件包,确认依赖解析正确
2. 验证软件包运行时链接到的 libdde-shell 版本符合预期
@sourcery-ai

sourcery-ai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Debian packaging dependency constraint for libdde-shell-dev in debian/control to better reflect the minimum required build-time version and avoid unnecessary conflicts with newer releases.

File-Level Changes

Change Details Files
Relax and correct the libdde-shell-dev build-dependency version constraint in the Debian control file.
  • Change the libdde-shell-dev Build-Depends version operator from a minimum-version constraint (>= 2.0.53) to a strictly-greater-than constraint relative to 2.0.52 (>> 2.0.52).
  • Align the documented minimum viable libdde-shell-dev version with what is actually used during builds.
  • Remove the implicit upper-bound constraint that could block installation when newer libdde-shell-dev versions are available.
debian/control

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码实现了构建依赖版本约束的合理放宽,无任何缺陷
语法逻辑完全正确且符合Debian规范,无扣分项

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

在debian/control文件中,将libdde-shell-dev的版本约束从>= 2.0.53修改为>> 2.0.52。根据Debian依赖语法,>>表示严格大于,该修改准确实现了放宽版本限制的意图,允许2.0.52.x等修复版本通过构建检查,语法与逻辑均无错误。

  • 2.代码质量(符合规范)✓

修改仅涉及单行版本号调整,且与上下文中部分依赖使用>>操作符的风格保持一致,符合Debian打包规范,无多余变更。

  • 3.代码性能(无性能问题)✓

构建依赖声明仅在dpkg-buildpackage解析阶段生效,不涉及运行时算法或系统调用,无性能影响。

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
此修改仅为构建系统元数据变更,不涉及可执行代码、命令执行、权限变更或敏感信息处理,无任何安全风险。

■ 【改进建议代码示例】

--- a/debian/control
+++ b/debian/control
@@ -25,7 +25,7 @@ Build-Depends:
  libdtk6gui-dev (>= 6.0.19),
  libdtk6declarative-dev (>> 6.7.33),
  dde-api-dev (>> 6.0.39),
- libdde-shell-dev (>= 2.0.53),
+ libdde-shell-dev (>> 2.0.52),
  libappstreamqt-dev (>= 1.0.0)
 Standards-Version: 4.6.0
 Rules-Requires-Root: no

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mhduiy

mhduiy commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

/forcemerge

@deepin-bot

deepin-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

This pr force merged! (status: blocked)

@deepin-bot
deepin-bot Bot merged commit 83831ec into linuxdeepin:master Aug 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants