fix(wireless): drop default MAC binding on connect - #608
Open
caixr23 wants to merge 1 commit into
Open
Conversation
1. Remove code that wrote the device permanent/real hardware address into the Wireless setting when creating or activating a connection (WirelessDeviceManagerRealize::connectNetwork, NetWirelessConnect::activateConnection) 2. Keep user-selected device binding in WirelessSection 3. A pinned MAC defeats random-MAC mode and blocks auto-connect after reboot, leaving wifi disconnected Log: Wireless auto-reconnects after reboot with random MAC enabled Influence: 1. Connect to WiFi, reboot, verify it reconnects automatically 2. Bind a wireless connection to a specific NIC in control center, verify profile keeps that mac-address 3. Choose "Not Bind", verify mac-address cleared from profile fix(wireless): 默认不再将连接绑定到网卡MAC地址 1. 移除创建/激活连接时将设备永久/真实硬件地址写入无线配置的代码 (WirelessDeviceManagerRealize::connectNetwork、 NetWirelessConnect::activateConnection) 2. 保留控制中心 WirelessSection 中用户手动选择的网卡绑定 3. 固定 MAC 会破坏随机 MAC 功能,且导致重启后无线无法自动回连 Log: 开启随机 MAC 后,重启系统可自动重连无线网络 Influence: 1. 连接 WiFi 后重启系统,验证能自动重连 2. 控制中心绑定指定网卡后,验证配置保留该 mac-address 3. 选择"不绑定",验证配置中 mac-address 已清空 PMS: BUG-374945
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves automatic persistence of a wireless device’s permanent MAC address during connection creation and activation, preventing interference with randomized-MAC auto-reconnect while leaving explicit user-selected bindings under WirelessSection control. Sequence diagram for wireless connection without default MAC bindingsequenceDiagram
participant User
participant WirelessDeviceManagerRealize
participant NetWirelessConnect
participant WirelessSection
participant ConnectionProfile
User->>WirelessDeviceManagerRealize: connectNetwork(accessPoint)
WirelessDeviceManagerRealize->>ConnectionProfile: setSsid(ssid)
WirelessDeviceManagerRealize->>ConnectionProfile: setInitialized(true)
User->>NetWirelessConnect: activateConnection()
NetWirelessConnect->>ConnectionProfile: setAutoconnect(false)
User->>WirelessSection: Select NIC binding or Not Bind
WirelessSection->>ConnectionProfile: setMacAddress(selectedMacOrEmpty)
ConnectionProfile-->>User: Profile keeps explicit binding or cleared MAC
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Wireless auto-reconnects after reboot with random MAC enabled
Influence:
fix(wireless): 默认不再将连接绑定到网卡MAC地址
Log: 开启随机 MAC 后,重启系统可自动重连无线网络
Influence:
PMS: BUG-374945
Summary by Sourcery
Remove the default wireless device MAC binding so connections can use random MAC addresses and reconnect automatically while retaining explicit user bindings.
Bug Fixes:
Enhancements: