fix: route publisher negotiation errors to reconnect instead of leaking them - #1226
Open
RaphaelFakhri wants to merge 3 commits into
Open
RaphaelFakhri wants to merge 3 commits into
RaphaelFakhri wants to merge 3 commits into
Conversation
RaphaelFakhri
requested review from
changt,
cloudwebrtc,
hiroshihorie and
xianshijing-lk
as code owners
September 29, 2026 09:59
Author
|
Valid finding, fixed in the new commit. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1093.
Transport.negotiateis a debounced function. The debouncer discards the future thatcreateAndSendOffer()returns, so a rejection (for examplesetLocalDescriptionfailing with "The order of m-lines in subsequent offer doesn't match") became an unhandled error. Thetry/catchinEngine.negotiatenever saw it, becausepublisher.negotiate(null)is not awaited and returns immediately. As a result, the reconnect that the catch block was meant to trigger never ran, and apps that installPlatformDispatcher.onErrorsaw the rawNegotiationError.This change:
Transport.onNegotiationError, and the debounced callback catches errors fromcreateAndSendOffer()and reports them through it.Engineto the previous catch-block logic: setfullReconnectOnNextfor aNegotiationError, then callhandleReconnect(negotiationFailed).try/catchfromEngine.negotiate.Test plan
test/core/transport_negotiate_test.dart:setLocalDescriptionrejects reports aNegotiationErrortoonNegotiationErrorand leaks no uncaught zone error;NegotiationError. After the change it passes.flutter analyze,dart format . --set-exit-if-changed,import_sorterand the fullflutter testsuite (440 tests) pass..changesentry.