Conversation
setMicrophoneEnabled(true, undefined, { preConnectBuffer: true }) starts the preconnect buffer on the new audio track, while a stray preConnectBuffer in the capture-options argument does not.
🦋 Changeset detectedLatest commit: 6958239 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
1egoman
reviewed
Oct 5, 2026
Comment on lines
+586
to
591
| const opts: TrackPublishOptions = { | ||
| ...this.roomOptions.publishDefaults, | ||
| ...publishOptions, | ||
| }; | ||
| for (const localTrack of localTracks) { | ||
| const opts: TrackPublishOptions = { | ||
| ...this.roomOptions.publishDefaults, | ||
| ...options, | ||
| }; | ||
| if ( |
Contributor
There was a problem hiding this comment.
thought: Would it be worth a preConnectBuffer: never in publishOptions or similar to ensure that a user doesn't pass options.publishDefaults by accident anymore? My understanding is that while this is a breaking change, it's actually a fix for a regression here so it's probably worth it.
I suppose another option could be to add publishDefaults in both places but I suspect that's probably more trouble than it is worth.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setMicrophoneEnabled(true, undefined, { preConnectBuffer: true }) starts the preconnect buffer on the new audio track, while a stray preConnectBuffer in the capture-options argument does not.