Skip to content

Remove stale commented-out multi-codec bitrate block - #2133

Merged
1egoman merged 1 commit into
mainfrom
fix/remove-stale-codec-bitrate-comment
Oct 5, 2026
Merged

1egoman merged 1 commit into
mainfrom
fix/remove-stale-codec-bitrate-comment

Conversation

@lukasIO

@lukasIO lukasIO commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

The block was added already commented out in 8cb17ec and never ran. Its
VP9 and H264 multipliers contradict the live values in
determineAppropriateEncoding, which match the Rust SDK, so the comment
was the stale side of the disagreement.

The block was added already commented out in 8cb17ec and never ran. Its
VP9 and H264 multipliers contradict the live values in
determineAppropriateEncoding, which match the Rust SDK, so the comment
was the stale side of the disagreement.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@changeset-bot

changeset-bot Bot commented Oct 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 63b1457

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 112.32 KB (0%)
dist/livekit-client.umd.js 121.45 KB (0%)

@1egoman
1egoman merged commit 8ad1ab5 into main Oct 5, 2026
6 checks passed
@1egoman
1egoman deleted the fix/remove-stale-codec-bitrate-comment branch October 5, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants