-
Notifications
You must be signed in to change notification settings - Fork 259
feat(telemetry): add the transport seam and LiveKit Cloud destinations #1480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pblazej
wants to merge
2
commits into
blaze/telemetry-stack/1-data-model
from
blaze/telemetry-stack/2-transport
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Default network transport cannot start
With only
netenabled,NetTransport::from_registry()returnsNoneunless the host registers a client.livekit-nethas no native backend enabled by default, leaving these builds unable to export telemetry.Learn more
The
netfeature activates the dependency but not its native backend. In a build that selects only this crate'snetfeature, http_client returnsNoneunless an application calledset_http_client, because native is disabled by default. NetTransport::from_registry therefore cannot construct the transport promised by this feature.Example: An application enables
livekit-telemetry/neton a native target without registering an HTTP client.from_registry()returnsNoneinstead of a built-in client, so no default exporter can send its batches.Recommended fix: Arrange for the native
livekit-netbackend and an appropriate TLS backend to be enabled for native default-transport builds, while retaining an explicit registered-client path for host-provided builds. Validate the standalonenetfeature without another dependency enablinglivekit-net/native.Was this helpful? React with 👍 or 👎 to provide feedback.