Repository navigation
Sign the webhook timestamp with the body (1.13.76) - #11
Merged
Merged
Conversation
X-LTAPI-Signature signs the raw body only, so a captured delivery verifies again when re-sent under a fresh X-LTAPI-Timestamp. The POST /webhooks description now documents X-LTAPI-Signature-V1 (t=<unix>,v1=<hex>, HMAC-SHA256 over "<t>.<raw body>") and the signed delivery_id in each body. It lists the receiver checks and calls the old header deprecated, dropped from 2027-02-01 00:00 UTC. The events enums now match what registration accepts: stoppages is gone from POST /webhooks, and the Webhook schema gains point and status. Generated pages rebuilt with scripts/build_reference.py.
bensynapse
force-pushed
the
fix/webhook-signature-timestamp
branch
from
October 28, 2026 04:31
ebda280 to
2bfe9e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the new webhook signature and bumps the spec to 1.13.76. The server side is bensynapse/tennisv1#12.
X-LTAPI-Signaturesigns the raw body only. A captured delivery still verifies when someone re-sends it later under a freshX-LTAPI-Timestamp. Deliveries now also carryX-LTAPI-Signature-V1: t=<unix seconds>,v1=<hex>, HMAC-SHA256 over<t>.<raw request body>with the same secret, plus a signeddelivery_idin the body.What changed, all in the webhook part of
openapi.yamlplusCHANGELOG.md:POST /webhooksdescription documents the V1 header anddelivery_id. It lists the receiver checks: a 5-minute window ontand a constant-time compare over the raw bytes. Then a dedupe ondelivery_id, and no fallback to the old header.X-LTAPI-Eventlist gainsscore_withdrawn, which the server already sends.eventsenums match what registration accepts.stoppagesis gone fromPOST /webhooks(registration answers 400 to it), and theWebhookschema gainspointandstatus.docs/*.html,docs/openapi.jsonanddocs/sitemap.xmlare regenerated.PR #10 also bumps the version (to 1.13.75) and touches the same generated files. This one takes 1.13.76. Whichever merges second needs
python scripts/build_reference.pyrun again after the rebase.Checked locally:
npx @redocly/cli@latest lint openapi.yaml: validpython scripts/build_reference.py --check: generated docs are currentsh scripts/truthcheck.sh: OKlint.yml: OK, 48 paths, 49 operations, 66 schemas