Skip to content

fix(clang-mlir): prevent llvm.mlir.undef on scalar brace initialization #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jimmy-Hu wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(clang-mlir): prevent llvm.mlir.undef on scalar brace initialization #446

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b328a46
fix(clang-mlir): prevent llvm.mlir.undef on scalar brace initialization
Jimmy-Hu Aug 31, 2026
f35b97a
fix(clang-mlir): handle ImplicitValueInitExpr in scalar brace initial…
Jimmy-Hu Aug 31, 2026
8577dba
fix(clang-mlir): support IndexType in VisitCXXScalarValueInitExpr
Jimmy-Hu Aug 31, 2026
3f6833c
fix(clang-mlir): support IndexType in VisitImplicitValueInitExpr
Jimmy-Hu Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions tools/cgeist/Lib/clang-mlir.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,8 +747,8 @@ MLIRScanner::VisitImplicitValueInitExpr(clang::ImplicitValueInitExpr *decl) {
return ValueCategory(builder.create<ConstantFloatOp>(
loc, APFloat(FT.getFloatSemantics(), "0"), FT),
/*isReference*/ false);
if (auto IT = dyn_cast<mlir::IntegerType>(Mty))
return ValueCategory(builder.create<ConstantIntOp>(loc, 0, IT),
if (Mty.isIntOrIndex())
return ValueCategory(builder.create<ConstantIntOp>(loc, 0, Mty),
/*isReference*/ false);
if (auto MT = dyn_cast<mlir::MemRefType>(Mty))
return ValueCategory(
Expand Down Expand Up @@ -1095,6 +1095,23 @@ ValueCategory MLIRScanner::VisitPredefinedExpr(clang::PredefinedExpr *expr) {
}

ValueCategory MLIRScanner::VisitInitListExpr(clang::InitListExpr *expr) {
if (expr->getNumInits() == 0 ||
(expr->getNumInits() == 1 && llvm::isa<clang::ImplicitValueInitExpr>(expr->getInit(0)))) {
mlir::Type elemType = getMLIRType(expr->getType());

if (elemType.isIntOrIndex()) {
auto zero = builder.create<mlir::arith::ConstantOp>(
getMLIRLocation(expr->getBeginLoc()),
builder.getIntegerAttr(elemType, 0));
return ValueCategory(zero, false);
}
else if (elemType.isa<mlir::FloatType>()) {
auto zero = builder.create<mlir::arith::ConstantOp>(
getMLIRLocation(expr->getBeginLoc()),
builder.getFloatAttr(elemType, 0.0));
return ValueCategory(zero, false);
}
}
mlir::Type subType = getMLIRType(expr->getType());
bool isArray = false;
bool LLVMABI = false;
Expand Down Expand Up @@ -1509,7 +1526,7 @@ MLIRScanner::VisitCXXScalarValueInitExpr(clang::CXXScalarValueInitExpr *expr) {
mlir::Type melem = Glob.getMLIRType(expr->getType(), &isArray);
assert(!isArray);

if (melem.isa<mlir::IntegerType>())
if (melem.isIntOrIndex())
return ValueCategory(builder.create<ConstantIntOp>(loc, 0, melem), false);
else if (auto MT = dyn_cast<mlir::MemRefType>(melem))
return ValueCategory(
Expand Down
Loading