smite: name the temporary_channel_id with a type alias - #226
Merged
Conversation
ekzyis
approved these changes
Sep 2, 2026
morehouse
approved these changes
Sep 2, 2026
morehouse
left a comment
morehouse
left a comment
Collaborator
There was a problem hiding this comment.
We also should convert Violation::InvalidAcceptChannel.
`open_channel` and its replies carry a `temporary_channel_id` that is a plain `ChannelId` on the wire, so every field and map keyed by it read as just another channel id. In particular, a signature such as `HashMap<ChannelId, PendingChannel>` did not say which of the two ids it was keyed by. Add `TemporaryChannelId` as an alias rather than a newtype: the wire format is identical and the compiler still treats both as one type, so this only documents which id a value holds, at no cost to the callers.
erickcestari
force-pushed
the
temporary-channel-id-alias
branch
from
September 2, 2026 18:02
6a92930 to
abe835b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open_channeland its replies carry atemporary_channel_idthat is a plainChannelIdon the wire, so every field and map keyed by it read as just another channel id. In particular, a signature such asHashMap<ChannelId, PendingChannel>did not say which of the two ids it was keyed by.Add
TemporaryChannelIdas an alias rather than a newtype: the wire format is identical and the compiler still treats both as one type, so this only documents which id a value holds, at no cost to the callers.