feat: attribute chat-cli group messages to their sender - #211
Open
mchenani wants to merge 5 commits into
Open
Conversation
jazzz
approved these changes
Aug 14, 2026
| /// Short label of the sender for an incoming message (`None` for our own | ||
| /// messages and system output). Used to attribute messages in groups. | ||
| #[serde(default)] | ||
| pub sender: Option<String>, |
Collaborator
There was a problem hiding this comment.
[Dust] No issue on a test app, but I would choose a dedicated enum rather than Option\<String\> for encoding this context.
- Encoding self as
Nonerequires an understanding of the type. - It's Ambiguous how to handle system notifications (Member Added, Description updated etc)
enum MessageOrigin { Self, Foreign(ShortAccountAddr) } leaves room for expansion to System, SelfOtherDevice etc, etc..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.