Only clear the forecast when the data source changes#707
Merged
Conversation
The refresh handler used to wipe the Loop and Trio forecasts on every refresh, including every websocket disconnect, which made the Loop forecast disappear and only come back on the next loop cycle. Move the clearing so it only happens when the active system actually changes: when a device status flips between Loop and Trio, and when Nightscout is turned off so there is no device status source at all, such as Dexcom only.
codebymini
previously approved these changes
Jul 17, 2026
codebymini
left a comment
codebymini
left a comment
Collaborator
There was a problem hiding this comment.
👍
Approve by code review and test.
The forecast was only rebuilt when the loop cycle advanced (previousLastLoopTime < lastLoopTime), so any time the prediction was cleared within the same cycle it stayed blank until the next loop cycle. Also rebuild when predictionData is empty, so the forecast is restored on the next device-status poll regardless of cycle timing.
A pump that omits pump.clock (e.g. some Omnipod configurations) left alertLastLoopTime at 0, so the Loop forecast anchored to epoch 0 and stretched the graph across decades. Use the loop cycle timestamp as the loop time when no pump clock is present, so the forecast anchors correctly and refreshes each cycle.
marionbarker
approved these changes
Jul 17, 2026
marionbarker
left a comment
marionbarker
left a comment
Collaborator
There was a problem hiding this comment.
Approve from code review and test with Loop URL from next-dev and Trio URL
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The refresh handler cleared the Loop and Trio forecasts on every refresh, including every websocket disconnect. On Loop that made the forecast vanish and only reappear on the next loop cycle, so on some instances it looked like it never came back.
The clearing now only happens when the active system actually changes. When a device status flips between Loop and Trio the previous system's forecast is dropped, and when Nightscout is turned off so there is no device status source, such as Dexcom only, both forecasts are cleared. Normal refreshes and websocket reconnects no longer touch the forecast.
Also rebuilds the Loop forecast whenever it is empty, not only when the loop cycle advances, so it is restored on the next device-status poll regardless of cycle timing.
For pumps that report no
pump.clock, the loop time now falls back to the loop cycle timestamp. Without it the loop time stayed 0, so the forecast anchored to epoch 0 and stretched the graph across decades.