馃悶fix: Output mapping of updated entities on merge - #26
Merged
lukaferlez merged 4 commits intoAug 17, 2026
Merged
Conversation
Updated rows returned by MERGE were matched back onto entities by primary key, so merging on any other columns left the generated key unmapped, as the entity has no key to match on yet. Match updated rows on the columns the merge was performed on instead, which is sound because a row comes back as an update precisely when it matched the entity on those columns. Matched entities that are already in sync produce no OUTPUT row at all, since Update() always added a difference check on the columns. Make that check optional through Update(checkConditionOnColumns) and expose it on UpsertAsync/UpsertBulkAsync, so callers can trade the extra writes for having every matched entity mapped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
lukaferlez
requested changes
Aug 4, 2026
| int? commandTimeout = null, | ||
| Action<MergeKeyOptions> key = null, | ||
| Action<IEnumerable<T>, IEnumerable<T>, IEnumerable<PropertyInfo>, IEnumerable<PropertyInfo>> outputMap = null, | ||
| bool checkConditionOnColumns = true, |
Owner
There was a problem hiding this comment.
To make this more readable/obvious of intent, I'd modify this where instead of the outputmap we will have OutputOptions object that will have an "outputmap" property and a "MapChangedOnly=true", so that you can then set that to false if you want.
Then we should add an override that would take in just the outputmap to maintain backward compatibility.
lukaferlez
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated rows returned by MERGE were matched back onto entities by primary key, so merging on any other columns left the generated key unmapped, as the entity has no key to match on yet. Match updated rows on the columns the merge was performed on instead, which is sound because a row comes back as an update precisely when it matched the entity on those columns.
Matched entities that are already in sync produce no OUTPUT row at all, since Update() always added a difference check on the columns. Make that check optional through Update(checkConditionOnColumns) and expose it on UpsertAsync/UpsertBulkAsync, so callers can trade the extra writes for having every matched entity mapped.