Skip to content

refactor: some small nitpicks - #104

Merged
mrcjkb merged 2 commits into
lumen-oss:mainfrom
teto:teto/nitpicks
Aug 4, 2026
Merged

mrcjkb merged 2 commits into
lumen-oss:mainfrom
teto:teto/nitpicks

Conversation

@teto

@teto teto commented Aug 4, 2026

Copy link
Copy Markdown
Member

extracted from another change I am making. To be read commit by commit.

dont hide the fallback "or pkg.rev" within the function
@teto
teto marked this pull request as draft August 4, 2026 12:02
just though it was more readable
@teto
teto marked this pull request as ready for review August 4, 2026 12:06
local version_tuple = pkg.ignore_tags and {} or git.get_latest_remote_semver_tag(pkg.url).wait()
---@cast version_tuple tag_version_tuple
local prev = pkg.rev or git.get_checked_out_rev(pkg)
local prev_rev = pkg.rev or git.get_checked_out_rev(pkg)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't like the merging of previous and rev into prev? 😂

@mrcjkb mrcjkb changed the title some small nitpicks refactor: some small nitpicks Aug 4, 2026
@mrcjkb
mrcjkb merged commit a647412 into lumen-oss:main Aug 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants