fix: #25 create parent directory for unnested addon zip entries - #30
Open
kelzcoded wants to merge 1 commit into
Open
fix: #25 create parent directory for unnested addon zip entries#30kelzcoded wants to merge 1 commit into
kelzcoded wants to merge 1 commit into
Conversation
m-triassi#25) Flat/unnested addon zips omit explicit directory entries for nested paths, so os.Create() failed on the target file because its parent directory was never created. MkdirAll the parent before creating the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25
Fixes
InstallAddonfailing on "unnested" addon zips by creating a parent directory before writing any files if one doesn't exist.Manually verified against a real addon zip (stripped the directory to reproduce the "unnested"/flat case). Also adds a test with a flat zip file and a "normal" one.